[Merged by Bors] - prevent memory leak when dropping ParallelSystemContainer #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
May 15, 2021
NathanSWard
approved these changes
May 16, 2021
Frizi
force-pushed
the
parallel-system-drop
branch
from
6327481
to
731e3b1
Compare
bjorn3
reviewed
May 16, 2021
Frizi
force-pushed
the
parallel-system-drop
branch
from
731e3b1
to
63ae37a
Compare
bjorn3
approved these changes
May 16, 2021
bjorn3
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
May 16, 2021
NathanSWard
approved these changes
May 17, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 17, 2021
`ParallelSystemContainer`'s `system` pointer was extracted from box, but it was never deallocated. This change adds missing drop implementation that cleans up that memory.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
…#2176) `ParallelSystemContainer`'s `system` pointer was extracted from box, but it was never deallocated. This change adds missing drop implementation that cleans up that memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParallelSystemContainer'ssystempointer was extracted from box, but it was never deallocated. This change adds missing drop implementation that cleans up that memory.