Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Derive Clone for Time #2360

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Derive Clone for Time #2360

wants to merge 1 commit into from

Conversation

CleanCut
Copy link
Member

@CleanCut CleanCut commented Jun 19, 2021

Objective

  • Make it so that Time can be cloned
  • Makes it so I can clone the entire current Time and easily pass it to the user in Rusty Engine instead of doing this

Solution

  • Derive the Clone trait on Time

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jun 19, 2021
@CleanCut CleanCut added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Triage This issue needs to be labelled labels Jun 19, 2021
@NathanSWard NathanSWard added A-Core Common functionality for all bevy apps C-Usability A simple quality-of-life change that makes Bevy easier to use labels Jun 19, 2021
@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jun 22, 2021
# Objective

- Make it so that `Time` can be cloned
- Makes it so I can clone the entire current `Time` and easily pass it to the user in [Rusty Engine](https://github.com/CleanCut/rusty_engine) instead of [doing this](https://github.com/CleanCut/rusty_engine/blob/8302dc3914d5b14b730e994cca452ce8d252fec2/src/game.rs#L147-L150)

## Solution

- Derive the `Clone` trait on `Time`
@bors bors bot changed the title Derive Clone for Time [Merged by Bors] - Derive Clone for Time Jun 22, 2021
@bors bors bot closed this Jun 22, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
# Objective

- Make it so that `Time` can be cloned
- Makes it so I can clone the entire current `Time` and easily pass it to the user in [Rusty Engine](https://github.com/CleanCut/rusty_engine) instead of [doing this](https://github.com/CleanCut/rusty_engine/blob/8302dc3914d5b14b730e994cca452ce8d252fec2/src/game.rs#L147-L150)

## Solution

- Derive the `Clone` trait on `Time`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core Common functionality for all bevy apps C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants