[Merged by Bors] - bevy_utils: Re-introduce with_capacity().
#2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR bevyengine#1235 had removed the `AHashExt` trait and respective `with_capacity()`s implementations, leaving only the less ergonomic `HashMap::with_capacity_and_hasher(size, Default::default())` option available. This re-introduces `AHashExt` and respective `with_capacity()` implementations to give a more ergonomic way to set a `HashMap` / `HashSet` capacity. As a note, this has also been discussed and agreed on issue bevyengine#2115, which this PR addresses. Fixes bevyengine#2115. Signed-off-by: Tiago Lam <tiagolam@gmail.com>
|
bors try |
tryBuild succeeded: |
mockersf
approved these changes
Jun 25, 2021
NathanSWard
approved these changes
Jun 25, 2021
NathanSWard
added
C-Enhancement
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 26, 2021
# Objective Re-introduce `AHashExt` and respective `with_capacity()` implementations to give a more ergonomic way to set a `HashMap` / `HashSet` capacity. As a note, this has also been discussed and agreed on issue #2115, which this PR addresses (leaving `new()` out of the `AHashExt` trait). Fixes #2115. ## Solution PR #1235 had removed the `AHashExt` trait and respective `with_capacity()`s implementations, leaving only the less ergonomic `HashMap::with_capacity_and_hasher(size, Default::default())` option available. This re-introduces `AHashExt` and respective `with_capacity()` implementations to give a more ergonomic way to set a `HashMap` / `HashSet` capacity.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
with_capacity().with_capacity().
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
# Objective Re-introduce `AHashExt` and respective `with_capacity()` implementations to give a more ergonomic way to set a `HashMap` / `HashSet` capacity. As a note, this has also been discussed and agreed on issue bevyengine#2115, which this PR addresses (leaving `new()` out of the `AHashExt` trait). Fixes bevyengine#2115. ## Solution PR bevyengine#1235 had removed the `AHashExt` trait and respective `with_capacity()`s implementations, leaving only the less ergonomic `HashMap::with_capacity_and_hasher(size, Default::default())` option available. This re-introduces `AHashExt` and respective `with_capacity()` implementations to give a more ergonomic way to set a `HashMap` / `HashSet` capacity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Re-introduce
AHashExtand respectivewith_capacity()implementations to give a more ergonomic way to set aHashMap/HashSetcapacity.As a note, this has also been discussed and agreed on issue #2115, which this PR addresses (leaving
new()out of theAHashExttrait).Fixes #2115.
Solution
PR #1235 had removed the
AHashExttrait and respectivewith_capacity()s implementations, leaving only the less ergonomicHashMap::with_capacity_and_hasher(size, Default::default())option available.This re-introduces
AHashExtand respectivewith_capacity()implementations to give a more ergonomic way to set aHashMap/HashSetcapacity.