Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update minimal version requirements for dependencies #2460

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Update minimal version requirements for dependencies #2460

wants to merge 1 commit into from

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Jul 13, 2021

This was tested using cargo generate-lockfile -Zminimal-versions.
The following indirect dependencies also have minimal version
dependencies. For at least num, rustc-serialize and rand this is
necessary to compile on rustc versions that are not older than 1.0.

  • num = "0.1.27"
  • rustc-serialize = "0.3.20"
  • termcolor = "1.0.4"
  • libudev-sys = "0.1.1"
  • rand = "0.3.14"
  • ab_glyph = "0.2.7

Based on #2455

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jul 13, 2021
@mockersf
Copy link
Member

for easy change comparison: bjorn3/bevy@remove_unused_deps...bjorn3:minimal_versions

why do you want to add minimal patch versions?

@mockersf mockersf added dependencies and removed S-Needs-Triage This issue needs to be labelled labels Jul 13, 2021
@bjorn3
Copy link
Contributor Author

bjorn3 commented Jul 13, 2021

To ensure that adding or updating bevy without a full cargo update will always work without problems. Currently if you already have say anyhow 1.0.0 in your Cargo.lock you will get a compilation error when adding bevy as new dependency. In the future it could happen that a fresh Cargo.lock generated at the time of the release of a certain bevy version will cause compilation to fail when bevy is updated to a new version in the future if the minimal version requirements in bevy are not updated to match reality.

@mockersf
Copy link
Member

Oh they broke backward compatibility between patch version... though that's a hard guarantee to make

@bjorn3
Copy link
Contributor Author

bjorn3 commented Jul 13, 2021

Anyhow only uses patch releases it seems. The current version is 1.0.42.

@cart cart added C-Dependencies A change to the crates that Bevy depends on and removed C-Dependencies-1 labels Jul 13, 2021
@bjorn3
Update minimal version requirements for dependencies
5d44404 
This was tested using cargo generate-lockfile -Zminimal-versions.
The following indirect dependencies also have minimal version
dependencies. For at least num, rustc-serialize and rand this is
necessary to compile on rustc versions that are not older than 1.0.

* num = "0.1.27"
* rustc-serialize = "0.3.20"
* termcolor = "1.0.4"
* libudev-sys = "0.1.1"
* rand = "0.3.14"
* ab_glyph = "0.2.7
@bjorn3
Copy link
Contributor Author

bjorn3 commented Jul 15, 2021

Rebased

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 15, 2021
@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 15, 2021
@bjorn3
Update minimal version requirements for dependencies (#2460)
fbf561c 
This was tested using cargo generate-lockfile -Zminimal-versions.
The following indirect dependencies also have minimal version
dependencies. For at least num, rustc-serialize and rand this is
necessary to compile on rustc versions that are not older than 1.0.

* num = "0.1.27"
* rustc-serialize = "0.3.20"
* termcolor = "1.0.4"
* libudev-sys = "0.1.1"
* rand = "0.3.14"
* ab_glyph = "0.2.7

Based on #2455
@bors
Copy link
Contributor

bors bot commented Jul 15, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Update minimal version requirements for dependencies [Merged by Bors] - Update minimal version requirements for dependencies Jul 15, 2021
@bors bors bot closed this Jul 15, 2021
@bjorn3 bjorn3 deleted the minimal_versions branch July 16, 2021 11:23
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
@bjorn3 @ostwilkens
Update minimal version requirements for dependencies (bevyengine#2460)
0b2a0e3 
This was tested using cargo generate-lockfile -Zminimal-versions.
The following indirect dependencies also have minimal version
dependencies. For at least num, rustc-serialize and rand this is
necessary to compile on rustc versions that are not older than 1.0.

* num = "0.1.27"
* rustc-serialize = "0.3.20"
* termcolor = "1.0.4"
* libudev-sys = "0.1.1"
* rand = "0.3.14"
* ab_glyph = "0.2.7

Based on bevyengine#2455
@dman-os dman-os mentioned this pull request Aug 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@NiklasEi NiklasEi NiklasEi approved these changes

Assignees
No one assigned
Labels
C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bjorn3 @mockersf @NiklasEi @cart