[Merged by Bors] - Add ClearColor Resource to Pipelined Renderer #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zicklag
force-pushed
the
clear-color-pipelined
branch
2 times, most recently
from
a4945ff
to
08eb731
Compare
cart
reviewed
Aug 13, 2021
pipelined/bevy_render2/src/lib.rs
Outdated
| @@ -178,6 +180,12 @@ impl Plugin for RenderPlugin { | |||
| } | |||
|
|
|||
| fn extract(app_world: &mut World, render_app: &mut App) { | |||
| // Update the render world clear color resource if it was added or changed in the app world | |||
| if app_world.is_resource_added::<ClearColor>() || app_world.is_resource_changed::<ClearColor>() | |||
There was a problem hiding this comment.
I don't think this should be updated here / hard coded in the "extract step execution logic". I think ClearColor should probably live in bevy_core_pipeline as it is behavior specific to "bevy's core render pipeline", not core renderer logic. It should just be another "extract stage system". That should also resolve the change tracking issue.
You should only need to query for Changed. "added" things also flip the "changed" flag.
There was a problem hiding this comment.
OK, cool, that makes sense. I'll update as soon as I get back to this. 👍
There was a problem hiding this comment.
Fixed it. I like that much better!
I'm really liking the extract →prepare →queue rendering model. Very nice.
alice-i-cecile
added
A-Rendering
zicklag
force-pushed
the
clear-color-pipelined
branch
2 times, most recently
from
bd7e8be
to
b36ab35
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 19, 2021
# Objective
- Allow the user to set the clear color when using the pipelined renderer
## Solution
- Add a `ClearColor` resource that can be added to the world to configure the clear color
## Remaining Issues
Currently the `ClearColor` resource is cloned from the app world to the render world every frame. There are two ways I can think of around this:
1. Figure out why `app_world.is_resource_changed::<ClearColor>()` always returns `true` in the `extract` step and fix it so that we are only updating the resource when it changes
2. Require the users to add the `ClearColor` resource to the render sub-app instead of the parent app. This is currently sub-optimal until we have labled sub-apps, and probably a helper funciton on `App` such as `app.with_sub_app(RenderApp, |app| { ... })`. Even if we had that, I think it would be more than we want the user to have to think about. They shouldn't have to know about the render sub-app I don't think.
I think the first option is the best, but I could really use some help figuring out the nuance of why `is_resource_changed` is always returning true in that context.
|
Pull request successfully merged into pipelined-rendering. Build succeeded: |
bors
bot
changed the title
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
ClearColorresource that can be added to the world to configure the clear colorRemaining Issues
Currently the
ClearColorresource is cloned from the app world to the render world every frame. There are two ways I can think of around this:app_world.is_resource_changed::<ClearColor>()always returnstruein theextractstep and fix it so that we are only updating the resource when it changesClearColorresource to the render sub-app instead of the parent app. This is currently sub-optimal until we have labled sub-apps, and probably a helper funciton onAppsuch asapp.with_sub_app(RenderApp, |app| { ... }). Even if we had that, I think it would be more than we want the user to have to think about. They shouldn't have to know about the render sub-app I don't think.I think the first option is the best, but I could really use some help figuring out the nuance of why
is_resource_changedis always returning true in that context.