Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Use RenderQueue in BufferVec #2847

Conversation

superdump
Copy link
Contributor

Using RenderQueue in BufferVec allows removal of the staging buffer entirely, as well as removal of the SpriteNode.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Needs-Review labels Sep 22, 2021
@cart
Copy link
Member

cart commented Oct 7, 2021

I think we'll be in a better spot once we update to the latest wgpu: gfx-rs/wgpu#1994 (comment)

@cart
Copy link
Member

cart commented Oct 7, 2021

bors r+

bors bot pushed a commit that referenced this pull request Oct 7, 2021
Using RenderQueue in BufferVec allows removal of the staging buffer entirely, as well as removal of the SpriteNode.

Co-authored-by: Carter Anderson <mcanders1@gmail.com>
@bors
Copy link
Contributor

bors bot commented Oct 7, 2021

@bors bors bot changed the title Use RenderQueue in BufferVec [Merged by Bors] - Use RenderQueue in BufferVec Oct 7, 2021
@bors bors bot closed this Oct 7, 2021
@mockersf mockersf added the hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event label Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants