Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Improve contributors example quality #3258

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - Improve contributors example quality #3258

wants to merge 8 commits into from

Conversation

CrazyRoka
Copy link
Contributor

Objective

Fixes #3181

Solution

Refactored contributors.rs example:

  • Renamed unclear variables
  • Split setup system into two separate systems

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 5, 2021
@CrazyRoka CrazyRoka mentioned this pull request Dec 5, 2021
Closed
@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples and removed S-Needs-Triage This issue needs to be labelled labels Dec 5, 2021
@alice-i-cecile
Copy link
Member

Solid improvements so far! Once we have a basic fallback for if the contributor list fails to load, I think this is good to merge :)

@CrazyRoka
Copy link
Contributor Author

@alice-i-cecile I have changed return type of contributors function and added default values instead. Have a look.

@CrazyRoka @alice-i-cecile
Update comment in contributors example
7155eac 
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
@CrazyRoka
Copy link
Contributor Author

@alice-i-cecile @MinerSebas Can you rerun checks and review my updates?

@alice-i-cecile
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Dec 7, 2021
@bors
Try #3258:
2a625d9
alice-i-cecile
alice-i-cecile approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; I'm happy with this now. bors try above was to rerun the CI for you.

@CrazyRoka
Copy link
Contributor Author

bors try

@bors
Copy link
Contributor

bors bot commented Dec 7, 2021

🔒 Permission denied

Existing reviewers: click here to make CrazyRoka a reviewer

@bors
Copy link
Contributor

bors bot commented Dec 7, 2021

try

Build succeeded:

cart
cart reviewed Dec 8, 2021
View reviewed changes
examples/2d/contributors.rs Outdated Show resolved Hide resolved
@cart
Copy link
Member

cart commented Dec 8, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 8, 2021
@CrazyRoka
Improve contributors example quality (#3258)
ca80fe6 
# Objective

Fixes #3181

## Solution

Refactored `contributors.rs` example:
- Renamed unclear variables
- Split setup system into two separate systems 


Co-authored-by: CrazyRoka <rokarostuk@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 8, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Improve contributors example quality [Merged by Bors] - Improve contributors example quality Dec 8, 2021
@bors bors bot closed this Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart left review comments

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@MinerSebas MinerSebas MinerSebas approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve code quality of contributors.rs example
4 participants
@CrazyRoka @alice-i-cecile @cart @MinerSebas