[Merged by Bors] - UI - keep color as 4 f32 #4494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparrett
reviewed
Apr 16, 2022
alice-i-cecile
added
C-Bug
Co-authored-by: Rob Parrett <robparrett@gmail.com>
rparrett
approved these changes
Apr 16, 2022
irate-devil
approved these changes
Apr 16, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Apr 16, 2022
mockersf
approved these changes
Apr 16, 2022
|
Identical to #4356. I feel comfortable merging this. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 25, 2022
# Objective - Fixes inaccurate UI colors similar to this [Sprite color fix](#4361). ## Solution - Do not reduce the color of UI quads to 4 u8. Left is the displayed color. Right is the input color(#202225). | Before Fix | After Fix | |--------|--------| |||
bors
bot
changed the title
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective - Fixes inaccurate UI colors similar to this [Sprite color fix](bevyengine#4361). ## Solution - Do not reduce the color of UI quads to 4 u8. Left is the displayed color. Right is the input color(#202225). | Before Fix | After Fix | |--------|--------| |||
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
|](https://user-images.githubusercontent.com/2303421/163661335-7f970a43-1f8b-45af-ae0a-cd74424aa9fb.png)||){kind=link}
# Objective - Fixes inaccurate UI colors similar to this [Sprite color fix](bevyengine#4361). ## Solution - Do not reduce the color of UI quads to 4 u8. Left is the displayed color. Right is the input color(#202225). | Before Fix | After Fix | |--------|--------| |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Left is the displayed color. Right is the input color(#202225).