[Merged by Bors] - Apply buffers in ParamSet
#4677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
added
C-Bug
|
I wonder if we ought to make that a non defaulted function to avoid this kind of error in the future, it would be only a single line of "noise" on trait impls that dont need to apply anything, and manually implementing this trait to begin with is remarkably niche (tbh same line of thought for |
BoxyUwU
approved these changes
May 6, 2022
alice-i-cecile
approved these changes
May 6, 2022
TheRawMeatball
approved these changes
May 6, 2022
|
@DJMcNab Can you add a quick test for this? Once that's done, I'm happy to merge it. |
|
Presumably we can't merge it until CI resurrects itself? |
|
#4675 was r+'ed an entire 4 minutes before you posted that ;) |
|
bors r+ |
alice-i-cecile
added
the
S-Ready-For-Final-Review
bors
bot
changed the title
ParamSetParamSet
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
May 10, 2022
# Objective - Fix bevyengine#4676 ## Solution - Fixes bevyengine#4676 - I have no reason to think this isn't sound, but `ParamSet` is a bit spooky
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective - Fix bevyengine#4676 ## Solution - Fixes bevyengine#4676 - I have no reason to think this isn't sound, but `ParamSet` is a bit spooky
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Fix bevyengine#4676 ## Solution - Fixes bevyengine#4676 - I have no reason to think this isn't sound, but `ParamSet` is a bit spooky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Commandsget ignored when usingParamSet(with minimum example) #4676Solution
Commandsget ignored when usingParamSet(with minimum example) #4676ParamSetis a bit spooky