[Merged by Bors] - Profile par_for_each(_mut) tasks #4711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
added
C-Enhancement
mockersf
reviewed
May 10, 2022
|
Agreed with Francois's suggestion on adding the number items in the batch. Otherwise this LGTM, and this is very useful functionality. |
alice-i-cecile
approved these changes
May 12, 2022
IceSentry
approved these changes
May 12, 2022
IceSentry
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
May 12, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 12, 2022
# Objective `Query::par_for_each` and it's variants do not show up when profiling using `tracy` or other profilers. Failing to show the impact of changing batch size, the overhead of scheduling tasks, overall thread utilization, etc. other than the effect on the surrounding system. ## Solution Add a child span that is entered on every spawned task. Example view of the results in `tracy` using a modified `parallel_query`:  --- ## Changelog Added: `tracing` spans for `Query::par_for_each` and its variants. Spans should now be visible for all
|
Build failed: |
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
May 13, 2022
# Objective `Query::par_for_each` and it's variants do not show up when profiling using `tracy` or other profilers. Failing to show the impact of changing batch size, the overhead of scheduling tasks, overall thread utilization, etc. other than the effect on the surrounding system. ## Solution Add a child span that is entered on every spawned task. Example view of the results in `tracy` using a modified `parallel_query`:  --- ## Changelog Added: `tracing` spans for `Query::par_for_each` and its variants. Spans should now be visible for all
bors
bot
changed the title
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
May 17, 2022
# Objective `Query::par_for_each` and it's variants do not show up when profiling using `tracy` or other profilers. Failing to show the impact of changing batch size, the overhead of scheduling tasks, overall thread utilization, etc. other than the effect on the surrounding system. ## Solution Add a child span that is entered on every spawned task. Example view of the results in `tracy` using a modified `parallel_query`:  --- ## Changelog Added: `tracing` spans for `Query::par_for_each` and its variants. Spans should now be visible for all
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective `Query::par_for_each` and it's variants do not show up when profiling using `tracy` or other profilers. Failing to show the impact of changing batch size, the overhead of scheduling tasks, overall thread utilization, etc. other than the effect on the surrounding system. ## Solution Add a child span that is entered on every spawned task. Example view of the results in `tracy` using a modified `parallel_query`:  --- ## Changelog Added: `tracing` spans for `Query::par_for_each` and its variants. Spans should now be visible for all
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective `Query::par_for_each` and it's variants do not show up when profiling using `tracy` or other profilers. Failing to show the impact of changing batch size, the overhead of scheduling tasks, overall thread utilization, etc. other than the effect on the surrounding system. ## Solution Add a child span that is entered on every spawned task. Example view of the results in `tracy` using a modified `parallel_query`:  --- ## Changelog Added: `tracing` spans for `Query::par_for_each` and its variants. Spans should now be visible for all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Query::par_for_eachand it's variants do not show up when profiling usingtracyor other profilers. Failing to show the impact of changing batch size, the overhead of scheduling tasks, overall thread utilization, etc. other than the effect on the surrounding system.Solution
Add a child span that is entered on every spawned task.
Example view of the results in
tracyusing a modifiedparallel_query:Changelog
Added:
tracingspans forQuery::par_for_eachand its variants. Spans should now be visible for all