[Merged by Bors] - Don't allocate for ComponentDescriptors of non-dynamic component types #4725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
changed the title
james7132
changed the title
alice-i-cecile
added
the
C-Performance
alice-i-cecile
approved these changes
May 12, 2022
TheRawMeatball
approved these changes
May 30, 2022
james7132
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 30, 2022
#4725) # Objective Don't allocate memory for Component types known at compile-time. Save a bit of memory. ## Solution Change `ComponentDescriptor::name` from `String` to `Cow<'static, str>` to use the `&'static str` returned by `std::any::type_name`.
bors
bot
changed the title
james7132
added a commit
to james7132/bevy
that referenced
this pull request
Jun 7, 2022
bevyengine#4725) # Objective Don't allocate memory for Component types known at compile-time. Save a bit of memory. ## Solution Change `ComponentDescriptor::name` from `String` to `Cow<'static, str>` to use the `&'static str` returned by `std::any::type_name`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
bevyengine#4725) # Objective Don't allocate memory for Component types known at compile-time. Save a bit of memory. ## Solution Change `ComponentDescriptor::name` from `String` to `Cow<'static, str>` to use the `&'static str` returned by `std::any::type_name`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Don't allocate memory for Component types known at compile-time. Save a bit of memory.
Solution
Change
ComponentDescriptor::namefromStringtoCow<'static, str>to use the&'static strreturned bystd::any::type_name.