Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - helper tool to build examples in wasm #4776

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - helper tool to build examples in wasm #4776

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

Objective

Solution

  • cargo run -p build-wasm-example -- lighting

@mockersf mockersf mentioned this pull request May 16, 2022
Closed
@mockersf mockersf added C-Examples An addition or correction to our examples O-Web Specific to web (WASM) builds labels May 16, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 17, 2022
@alice-i-cecile
Copy link
Member

Since the gitpod part is controversial. Can you extract the wasm build tool to a separate PR since that part is not really controversial and makes building wasm simpler.

Yeah I'd merge this asap if it was split out.

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request May 17, 2022
@mockersf
helper tool to build examples in wasm (#4776)
ae0cb54 
# Objective

- add an helper to build examples in wasm (from #4700)

## Solution

- `cargo run -p build-wasm-example -- lighting`
@bors
Copy link
Contributor

bors bot commented May 17, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title helper tool to build examples in wasm [Merged by Bors] - helper tool to build examples in wasm May 17, 2022
@bors bors bot closed this May 17, 2022
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
@mockersf @exjam
helper tool to build examples in wasm (bevyengine#4776)
adee0d2 
# Objective

- add an helper to build examples in wasm (from bevyengine#4700)

## Solution

- `cargo run -p build-wasm-example -- lighting`
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
helper tool to build examples in wasm (bevyengine#4776)
960ddbd 
# Objective

- add an helper to build examples in wasm (from bevyengine#4700)

## Solution

- `cargo run -p build-wasm-example -- lighting`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@IceSentry IceSentry IceSentry approved these changes

Assignees
No one assigned
Labels
C-Examples An addition or correction to our examples O-Web Specific to web (WASM) builds S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mockersf @alice-i-cecile @IceSentry