Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Update gilrs to v0.9 #4848

Closed
wants to merge 4 commits into from

Conversation

james7132
Copy link
Member

@james7132 james7132 commented May 26, 2022

Objective

Fixes #4353. Fixes #4431. Picks up fixes for a panic for gilrs when getGamepads() is not available.

Solution

Update the gilrs to v0.9.0. Changelog can be seen here: https://gitlab.com/gilrs-project/gilrs/-/commit/dba36f91869c823fb66f8633d2b650b430682f80

EDIT: Updated uuid to 1.1 to avoid duplicate dependencies. Added nix's two dependencies as exceptions until rodio updates their deps.

@mockersf
Copy link
Member

two duplicate dependencies:

@james7132 james7132 added C-Bug An unexpected or incorrect behavior A-Input Player input via keyboard, mouse, gamepad, and more C-Dependencies A change to the crates that Bevy depends on O-Web Specific to web (WASM) builds labels May 26, 2022
@james7132 james7132 requested a review from mockersf May 26, 2022 10:07
deny.toml Outdated Show resolved Hide resolved
Co-authored-by: François <mockersf@gmail.com>
@alice-i-cecile
Copy link
Member

bors r+

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 30, 2022
bors bot pushed a commit that referenced this pull request May 30, 2022
# Objective
Fixes #4353. Fixes #4431. Picks up fixes for a panic for `gilrs` when `getGamepads()` is not available. 

## Solution
Update the `gilrs` to `v0.9.0`. Changelog can be seen here: https://gitlab.com/gilrs-project/gilrs/-/commit/dba36f91869c823fb66f8633d2b650b430682f80

EDIT: Updated `uuid` to 1.1 to avoid duplicate dependencies. Added `nix`'s two dependencies as exceptions until `rodio` updates their deps.
@bors bors bot changed the title Update gilrs to v0.9 [Merged by Bors] - Update gilrs to v0.9 May 30, 2022
@bors bors bot closed this May 30, 2022
james7132 added a commit to james7132/bevy that referenced this pull request Jun 7, 2022
# Objective
Fixes bevyengine#4353. Fixes bevyengine#4431. Picks up fixes for a panic for `gilrs` when `getGamepads()` is not available. 

## Solution
Update the `gilrs` to `v0.9.0`. Changelog can be seen here: https://gitlab.com/gilrs-project/gilrs/-/commit/dba36f91869c823fb66f8633d2b650b430682f80

EDIT: Updated `uuid` to 1.1 to avoid duplicate dependencies. Added `nix`'s two dependencies as exceptions until `rodio` updates their deps.
@james7132 james7132 deleted the gilrs-v0.9 branch June 22, 2022 08:19
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective
Fixes bevyengine#4353. Fixes bevyengine#4431. Picks up fixes for a panic for `gilrs` when `getGamepads()` is not available. 

## Solution
Update the `gilrs` to `v0.9.0`. Changelog can be seen here: https://gitlab.com/gilrs-project/gilrs/-/commit/dba36f91869c823fb66f8633d2b650b430682f80

EDIT: Updated `uuid` to 1.1 to avoid duplicate dependencies. Added `nix`'s two dependencies as exceptions until `rodio` updates their deps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Bug An unexpected or incorrect behavior C-Dependencies A change to the crates that Bevy depends on O-Web Specific to web (WASM) builds S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
3 participants