Add error when extract resource build fails #4964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
|
Another one for #1255... |
alice-i-cecile
approved these changes
Jun 7, 2022
superdump
requested changes
Jun 8, 2022
There was a problem hiding this comment.
I feel like a .expect() is appropriate here. It should be a fatal error imo as the code is wrong. Also, why did the render app not exist yet? This is a plugin. Did you add it before DefaultPlugins or something? @alice-i-cecile @cart what do you think? Fatal or not?
|
Definitely fatal; I don't think there's any way to recover from this. The fix is always just "order your plugins better", as much as I hate that. |
|
Good point. |
aevyrie
force-pushed
the
extract-res-error
branch
from
baca764
to
496ccef
Compare
|
Iirc we adopted the |
superdump
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
I had some troubleshooting pain when this happened to me, as the panic only tells you a resource is missing. This PR adds an error when the ExtractResource plugin is added before the render world exists, instead of silently failing.