Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - unpin nightly and disable weak memory emulation #4988

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - unpin nightly and disable weak memory emulation #4988

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a14a5c
unpin nightly and disable weak memory emulation
mockersf Jun 11, 2022
e7a8888
use miri-permissive-provenance
mockersf Jun 27, 2022
1e5b442
update comments
mockersf Jun 27, 2022
0b73374
update comment
mockersf Jun 27, 2022
2d6d42e
update comment with issue link
mockersf Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,20 +76,18 @@ jobs:
timeout-minutes: 60
steps:
- uses: actions/checkout@v3
# TODO: re-enable cache once nightly is unpinned
# - uses: actions/cache@v3
# with:
# path: |
# ~/.cargo/bin/
# ~/.cargo/registry/index/
# ~/.cargo/registry/cache/
# ~/.cargo/git/db/
# target/
# key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.toml') }}
- uses: actions/cache@v3
with:
path: |
~/.cargo/bin/
~/.cargo/registry/index/
~/.cargo/registry/cache/
~/.cargo/git/db/
target/
key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.toml') }}
- uses: actions-rs/toolchain@v1
with:
# TODO: check again with nightly once https://github.com/rust-lang/miri/issues/2223 is fixed
toolchain: nightly-2022-06-08
toolchain: nightly
components: miri
override: true
- name: Install alsa and udev
Expand All @@ -99,12 +97,14 @@ jobs:
env:
# -Zrandomize-layout makes sure we dont rely on the layout of anything that might change
RUSTFLAGS: -Zrandomize-layout
# https://github.com/rust-lang/miri#miri--z-flags-and-environment-variables
# -Zmiri-disable-isolation is needed because our executor uses `fastrand` which accesses system time.
# -Zmiri-ignore-leaks is needed because running bevy_ecs tests finds a memory leak but its impossible
# to track down because allocids are nondeterministic.
# -Zmiri-tag-raw-pointers is not strictly "necessary" but enables a lot of extra UB checks relating
# to raw pointer aliasing rules that we should be trying to uphold.
MIRIFLAGS: -Zmiri-disable-isolation -Zmiri-ignore-leaks -Zmiri-tag-raw-pointers
# -Zmiri-permissive-provenance enables extra UB checks relating to raw pointer aliasing rules that we
# should be trying to uphold.
mockersf marked this conversation as resolved.
Show resolved Hide resolved
# -Zmiri-disable-weak-memory-emulation works around an unknown bug in Bevy or Miri.
mockersf marked this conversation as resolved.
Show resolved Hide resolved
MIRIFLAGS: -Zmiri-disable-isolation -Zmiri-ignore-leaks -Zmiri-permissive-provenance -Zmiri-disable-weak-memory-emulation

check-compiles:
runs-on: ubuntu-latest
Expand Down