Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix clap for CI #5005

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix clap for CI #5005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions tools/build-wasm-example/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,18 @@ use xshell::{cmd, Shell};
#[derive(Parser, Debug)]
struct Args {
/// Examples to build
#[clap(value_parser)]
examples: Vec<String>,

#[clap(short, long)]
#[clap(short, long, value_parser)]
/// Run tests
test: bool,

#[clap(short, long)]
#[clap(short, long, value_parser)]
/// Run on the given browsers. By default, chromium, firefox, webkit
browsers: Vec<String>,

#[clap(short, long)]
#[clap(short, long, value_parser)]
/// Stop after this number of frames
frames: Option<usize>,
}
Expand Down
8 changes: 5 additions & 3 deletions tools/spancmp/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,22 @@ mod pretty;

#[derive(Parser, Debug)]
struct Args {
#[clap(short, long, default_value_t = 0.0)]
#[clap(short, long, value_parser, default_value_t = 0.0)]
/// Filter spans that have an average shorther than the threshold
threshold: f32,

#[clap(short, long)]
#[clap(short, long, value_parser)]
/// Filter spans by name matching the pattern
pattern: Option<Regex>,

#[clap(short, long)]
#[clap(short, long, value_parser)]
/// Simplify system names
short: bool,

#[clap(value_parser)]
trace: String,
/// Optional, second trace to compare
#[clap(value_parser)]
second_trace: Option<String>,
}

Expand Down