Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Separate PBR and tone mapping into 2 functions #5078

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Separate PBR and tone mapping into 2 functions #5078

wants to merge 1 commit into from

Conversation

cryscan
Copy link
Contributor

@cryscan cryscan commented Jun 23, 2022

Objective

  • Allow custom shaders to reuse the HDR results of PBR.

Solution

  • Separate pbr() and tone_mapping() into 2 functions in pbr_functions.wgsl.

@superdump superdump added C-Enhancement A new feature A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use labels Jun 23, 2022
@superdump
Copy link
Contributor

I hadn't done this as tonemapping is going to be separated out fully shortly and so it would be done as part of that. I think @cart was looking into that?

@DGriffin91
Copy link
Contributor

@superdump I think this would be useful in the meantime. It would allow for people to implement their own tonemapping, or bypass it completely. (which I need to do for creating environment maps)

@alice-i-cecile alice-i-cecile removed the C-Enhancement A new feature label Jun 25, 2022
@superdump
Copy link
Contributor

bors r+

bors bot pushed a commit that referenced this pull request Jun 26, 2022
@cryscan
Separate PBR and tone mapping into 2 functions (#5078)
92eec47 
# Objective

- Allow custom shaders to reuse the HDR results of PBR.

## Solution

- Separate `pbr()` and `tone_mapping()` into 2 functions in `pbr_functions.wgsl`.
@bors
Copy link
Contributor

bors bot commented Jun 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Separate PBR and tone mapping into 2 functions [Merged by Bors] - Separate PBR and tone mapping into 2 functions Jun 26, 2022
@bors bors bot closed this Jun 26, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
@cryscan @inodentry
Separate PBR and tone mapping into 2 functions (bevyengine#5078)
8a5c043 
# Objective

- Allow custom shaders to reuse the HDR results of PBR.

## Solution

- Separate `pbr()` and `tone_mapping()` into 2 functions in `pbr_functions.wgsl`.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@cryscan @james7132
Separate PBR and tone mapping into 2 functions (bevyengine#5078)
2e0ec34 
# Objective

- Allow custom shaders to reuse the HDR results of PBR.

## Solution

- Separate `pbr()` and `tone_mapping()` into 2 functions in `pbr_functions.wgsl`.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@cryscan @ItsDoot
Separate PBR and tone mapping into 2 functions (bevyengine#5078)
ab579c8 
# Objective

- Allow custom shaders to reuse the HDR results of PBR.

## Solution

- Separate `pbr()` and `tone_mapping()` into 2 functions in `pbr_functions.wgsl`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@DGriffin91 DGriffin91 DGriffin91 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cryscan @superdump @DGriffin91 @alice-i-cecile