[Merged by Bors] - Add inverse_projection and inverse_view_proj fields to shader view uniform
#5119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superdump
requested changes
Jun 27, 2022
Co-authored-by: Robert Swain <robert.swain@gmail.com>
superdump
approved these changes
Jun 28, 2022
superdump
added
A-Rendering
james7132
approved these changes
Jul 2, 2022
james7132
added
the
S-Ready-For-Final-Review
HackerFoo
approved these changes
Jul 2, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 4, 2022
…w uniform (#5119) # Objective Transform screen-space coordinates into world space in shaders. (My use case is for generating rays for ray tracing with the same perspective as the 3d camera). ## Solution Add `inverse_projection` and `inverse_view_proj` fields to shader view uniform --- ## Changelog ### Added `inverse_projection` and `inverse_view_proj` fields to shader view uniform ## Note It'd probably be good to double-check that I did the matrix multiplication in the right order for `inverse_proj_view`. Thanks!
bors
bot
changed the title
inverse_projection and inverse_view_proj fields to shader view uniforminverse_projection and inverse_view_proj fields to shader view uniform
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
…w uniform (bevyengine#5119) # Objective Transform screen-space coordinates into world space in shaders. (My use case is for generating rays for ray tracing with the same perspective as the 3d camera). ## Solution Add `inverse_projection` and `inverse_view_proj` fields to shader view uniform --- ## Changelog ### Added `inverse_projection` and `inverse_view_proj` fields to shader view uniform ## Note It'd probably be good to double-check that I did the matrix multiplication in the right order for `inverse_proj_view`. Thanks!
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…w uniform (bevyengine#5119) # Objective Transform screen-space coordinates into world space in shaders. (My use case is for generating rays for ray tracing with the same perspective as the 3d camera). ## Solution Add `inverse_projection` and `inverse_view_proj` fields to shader view uniform --- ## Changelog ### Added `inverse_projection` and `inverse_view_proj` fields to shader view uniform ## Note It'd probably be good to double-check that I did the matrix multiplication in the right order for `inverse_proj_view`. Thanks!
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…w uniform (bevyengine#5119) # Objective Transform screen-space coordinates into world space in shaders. (My use case is for generating rays for ray tracing with the same perspective as the 3d camera). ## Solution Add `inverse_projection` and `inverse_view_proj` fields to shader view uniform --- ## Changelog ### Added `inverse_projection` and `inverse_view_proj` fields to shader view uniform ## Note It'd probably be good to double-check that I did the matrix multiplication in the right order for `inverse_proj_view`. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Transform screen-space coordinates into world space in shaders. (My use case is for generating rays for ray tracing with the same perspective as the 3d camera).
Solution
Add
inverse_projectionandinverse_view_projfields to shader view uniformChangelog
Added
inverse_projectionandinverse_view_projfields to shader view uniformNote
It'd probably be good to double-check that I did the matrix multiplication in the right order for
inverse_proj_view. Thanks!