[Merged by Bors] - android - fix issues other than the rendering #5130

mockersf · 2022-06-29T00:37:29Z

Objective

Make Bevy work on android

Solution

Update android metadata and add a few more
Set the target sdk to 31 as it will soon (in august) be the minimum sdk level for play store
Remove the custom code to create an activity and use ndk-glue macro instead
Delay window creation event on android
Set the example with compatibility settings for wgpu. Those are needed for Bevy to work on my 2019 android tablet
Add a few details on how to debug in case of failures
Fix running the example on emulator. This was failing because of the name of the example

Bevy still doesn't work on android with this, audio features need to be disabled because of an ndk-glue version mismatch: rodio depends on 0.6.2, winit on 0.5.2. You can test with:

cargo apk run --release --example android_example --no-default-features --features "bevy_winit,render"

crates/bevy_derive/src/bevy_main.rs

examples/android/android.rs

Co-Authored-By: Alice Cecile <alice.i.cecile@gmail.com>

crates/bevy_derive/src/bevy_main.rs

Co-Authored-By: SarthakSingh31 <35749450+SarthakSingh31@users.noreply.github.com>

mockersf · 2022-06-29T11:51:17Z

Recorded on device:

device-2022-06-29-134401.mp4

Also works on emulator but it's much slower there

mockersf · 2022-06-29T19:30:14Z

bors try

examples/android/android.rs

bors · 2022-06-29T19:54:13Z

try

Build succeeded:

cart · 2022-06-29T19:56:21Z

Tried running this and I'm getting a link error on my new Pixel 6:

06-29 14:51:29.898 13254 13254 E AndroidRuntime: java.lang.UnsatisfiedLinkError: Unable to load native library "/data/app/~~m4g7axUMj33njZDZE6J9Sw==/org.bevyengine.example-czbVgT7PSmsP6pipS0Aong==/lib/arm64/libandroid_example.so": dlopen failed: cannot locate symbol "__cxa_pure_virtual" referenced by "/data/app/~~m4g7axUMj33njZDZE6J9Sw==/org.bevyengine.example-czbVgT7PSmsP6pipS0Aong==/lib/arm64/libandroid_example.so"...

cart · 2022-06-29T20:02:39Z

Seems like I'm hitting this: katyo/oboe-rs#28 (comment)
Mentioned in #4103

cart · 2022-06-29T20:03:32Z

Ahh I didn't fully read the pr description. Ill try without audio features. Oops :)

cart · 2022-06-29T21:03:14Z

Disabling audio did fix the problem. But its pretty inconsistent about whether or not it will work. Sometimes it starts up just fine. Other times I get a black screen.

mockersf · 2022-06-29T21:11:22Z

But its pretty inconsistent about whether or not it will work. Sometimes it starts up just fine. Other times I get a black screen.

Well... still an improvement 😄

Do you have anything in logs when it's a black screen?

komadori · 2022-06-30T00:06:06Z

I've tried running the example on my Samsung S21+ and it occasionally works when I start the app, but I more often than not I get a black screen. The following message appears the adb logcat output and I assume is the crux of the problem:

RustStdoutStderr: thread '<unnamed>' panicked at 'Cannot get the native window, it's null and will always be null before Event::Resumed and after Event::Suspended. Make sure you only call this function between those events.', /home/komadori/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.26.1/src/platform_impl/android/mod.rs:598:13

mockersf · 2022-06-30T05:09:44Z

Thanks for testing and reporting the issue!

So it seems this PR doesn't fix that issue, it just happens less often. I would like to keep this PR free of rendering fix so that it doesn't become controversial...

@cart would you agree on moving on with this PR as a first step to fix metadata, naming, and so on? I'll open more controversial PRs for the rest 😄

alice-i-cecile · 2022-06-30T15:43:16Z

I'm in favor of merging this ASAP; it clearly improves matters, and Android is already broken so the user impact is 0.

komadori

In the context of @alice-i-cecile's comment, I think this PR is good.

cart · 2022-06-30T16:55:48Z

Yeah happy to iterate on this and these changes are good!

cart · 2022-06-30T16:55:55Z

bors r+

# Objective - Make Bevy work on android ## Solution - Update android metadata and add a few more - Set the target sdk to 31 as it will soon (in august) be the minimum sdk level for play store - Remove the custom code to create an activity and use ndk-glue macro instead - Delay window creation event on android - Set the example with compatibility settings for wgpu. Those are needed for Bevy to work on my 2019 android tablet - Add a few details on how to debug in case of failures - Fix running the example on emulator. This was failing because of the name of the example Bevy still doesn't work on android with this, audio features need to be disabled because of an ndk-glue version mismatch: rodio depends on 0.6.2, winit on 0.5.2. You can test with: ``` cargo apk run --release --example android_example --no-default-features --features "bevy_winit,render" ```

bors · 2022-06-30T17:03:15Z

Build failed:

check-unused-dependencies

cart · 2022-06-30T19:42:27Z

bors r+

# Objective - Make Bevy work on android ## Solution - Update android metadata and add a few more - Set the target sdk to 31 as it will soon (in august) be the minimum sdk level for play store - Remove the custom code to create an activity and use ndk-glue macro instead - Delay window creation event on android - Set the example with compatibility settings for wgpu. Those are needed for Bevy to work on my 2019 android tablet - Add a few details on how to debug in case of failures - Fix running the example on emulator. This was failing because of the name of the example Bevy still doesn't work on android with this, audio features need to be disabled because of an ndk-glue version mismatch: rodio depends on 0.6.2, winit on 0.5.2. You can test with: ``` cargo apk run --release --example android_example --no-default-features --features "bevy_winit,render" ```

bors · 2022-06-30T20:03:32Z

Pull request successfully merged into main.

Build succeeded:

# Objective - Make Bevy work on android ## Solution - Update android metadata and add a few more - Set the target sdk to 31 as it will soon (in august) be the minimum sdk level for play store - Remove the custom code to create an activity and use ndk-glue macro instead - Delay window creation event on android - Set the example with compatibility settings for wgpu. Those are needed for Bevy to work on my 2019 android tablet - Add a few details on how to debug in case of failures - Fix running the example on emulator. This was failing because of the name of the example Bevy still doesn't work on android with this, audio features need to be disabled because of an ndk-glue version mismatch: rodio depends on 0.6.2, winit on 0.5.2. You can test with: ``` cargo apk run --release --example android_example --no-default-features --features "bevy_winit,render" ```

mockersf added 5 commits June 29, 2022 02:29

update metadata about android

c18fb60

use ndk-glue macro

3daf5ac

delay window creation event on android

6696086

setup wgpu for compatibility

093900e

add debugging info

844bbec

mockersf added the O-Android Specific to the Android mobile operating system label Jun 29, 2022

alice-i-cecile added the C-Bug An unexpected or incorrect behavior label Jun 29, 2022

alice-i-cecile added this to the Bevy 0.8 milestone Jun 29, 2022

add language fences

a5097e3

alice-i-cecile added the P-High This is particularly urgent, and deserves immediate attention label Jun 29, 2022

alice-i-cecile reviewed Jun 29, 2022

View reviewed changes

crates/bevy_derive/src/bevy_main.rs Show resolved Hide resolved

alice-i-cecile reviewed Jun 29, 2022

View reviewed changes

examples/android/android.rs Outdated Show resolved Hide resolved

improve comment

4548677

Co-Authored-By: Alice Cecile <alice.i.cecile@gmail.com>

alice-i-cecile reviewed Jun 29, 2022

View reviewed changes

crates/bevy_derive/src/bevy_main.rs Show resolved Hide resolved

mockersf and others added 2 commits June 29, 2022 03:13

add comment about ndk-glue main macro

60f1df2

fix example on emulator

9fcab5e

Co-Authored-By: SarthakSingh31 <35749450+SarthakSingh31@users.noreply.github.com>

mockersf force-pushed the another-attempt-at-fixing-android branch from d4601b4 to 9fcab5e Compare June 29, 2022 02:10

increase the maximum screen size supported

cda3a22

fix CI job

b8398f4

bors bot added a commit that referenced this pull request Jun 29, 2022

Try #5130:

121a577

cart reviewed Jun 29, 2022

View reviewed changes

examples/android/android.rs Outdated Show resolved Hide resolved

not needed to override wgpu limits

f56f85c

mockersf changed the title ~~fix startup on android~~ android - fix issues other than the rendering Jun 30, 2022

alice-i-cecile approved these changes Jun 30, 2022

View reviewed changes

komadori approved these changes Jun 30, 2022

View reviewed changes

alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 30, 2022

bors bot changed the title ~~android - fix issues other than the rendering~~ [Merged by Bors] - android - fix issues other than the rendering Jun 30, 2022

bors bot closed this Jun 30, 2022

cart mentioned this pull request Jul 8, 2022

Deferred render init #4913

Closed

Weibye mentioned this pull request Aug 10, 2022

[Merged by Bors] - Windows as Entities #5589

Closed

Gordon-F mentioned this pull request Aug 21, 2022

Get raw window handle only after Resume event #3639

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - android - fix issues other than the rendering #5130

[Merged by Bors] - android - fix issues other than the rendering #5130

mockersf commented Jun 29, 2022 •

edited

Loading

mockersf commented Jun 29, 2022 •

edited

Loading

mockersf commented Jun 29, 2022

bors bot commented Jun 29, 2022

cart commented Jun 29, 2022

cart commented Jun 29, 2022

cart commented Jun 29, 2022

cart commented Jun 29, 2022

mockersf commented Jun 29, 2022

komadori commented Jun 30, 2022

mockersf commented Jun 30, 2022

alice-i-cecile commented Jun 30, 2022

komadori left a comment

cart commented Jun 30, 2022

cart commented Jun 30, 2022

bors bot commented Jun 30, 2022

cart commented Jun 30, 2022

bors bot commented Jun 30, 2022

[Merged by Bors] - android - fix issues other than the rendering #5130

[Merged by Bors] - android - fix issues other than the rendering #5130

Conversation

mockersf commented Jun 29, 2022 • edited Loading

Objective

Solution

mockersf commented Jun 29, 2022 • edited Loading

mockersf commented Jun 29, 2022

bors bot commented Jun 29, 2022

try

cart commented Jun 29, 2022

cart commented Jun 29, 2022

cart commented Jun 29, 2022

cart commented Jun 29, 2022

mockersf commented Jun 29, 2022

komadori commented Jun 30, 2022

mockersf commented Jun 30, 2022

alice-i-cecile commented Jun 30, 2022

komadori left a comment

Choose a reason for hiding this comment

cart commented Jun 30, 2022

cart commented Jun 30, 2022

bors bot commented Jun 30, 2022

cart commented Jun 30, 2022

bors bot commented Jun 30, 2022

mockersf commented Jun 29, 2022 •

edited

Loading

mockersf commented Jun 29, 2022 •

edited

Loading