Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Removed world cell from places where split multable access is not needed #5167

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Removed world cell from places where split multable access is not needed #5167

wants to merge 1 commit into from

Conversation

SarthakSingh31
Copy link
Contributor

Fixes #5109.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Jul 1, 2022
alice-i-cecile
alice-i-cecile approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 1, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 1, 2022
@SarthakSingh31
Removed world cell from places where split multable access is not nee…
cdbabb7 
…ded (#5167)

Fixes #5109.
@bors
Copy link
Contributor

bors bot commented Jul 1, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Removed world cell from places where split multable access is not needed [Merged by Bors] - Removed world cell from places where split multable access is not needed Jul 1, 2022
@bors bors bot closed this Jul 1, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
@SarthakSingh31 @inodentry
Removed world cell from places where split multable access is not nee…
69ece68 
…ded (bevyengine#5167)

Fixes bevyengine#5109.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@SarthakSingh31 @james7132
Removed world cell from places where split multable access is not nee…
43525fb 
…ded (bevyengine#5167)

Fixes bevyengine#5109.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@SarthakSingh31 @ItsDoot
Removed world cell from places where split multable access is not nee…
d82fea0 
…ded (bevyengine#5167)

Fixes bevyengine#5109.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unnecessary usages of WorldCell API
3 participants
@SarthakSingh31 @alice-i-cecile @mockersf