[Merged by Bors] - bevy_reflect: support map insertion #5173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
added
C-Enhancement
MrGVSV
approved these changes
Jul 2, 2022
alice-i-cecile
approved these changes
Jul 2, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
PROMETHIA-27
approved these changes
Jul 2, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 4, 2022
# Objective This is a rebase of #3701 which is currently scheduled for 0.8 but is marked for adoption. > Fixes #3609 ## Solution > - add an `insert_boxed()` method on the `Map` trait > - implement it for `HashMap` using a new `FromReflect` generic bound > - add a `map_apply()` helper method to implement `Map::apply()`, that inserts new values instead of ignoring them --- ## Changelog TODO Co-authored-by: james7132 <contact@jamessliu.com>
bors
bot
changed the title
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
# Objective This is a rebase of bevyengine#3701 which is currently scheduled for 0.8 but is marked for adoption. > Fixes bevyengine#3609 ## Solution > - add an `insert_boxed()` method on the `Map` trait > - implement it for `HashMap` using a new `FromReflect` generic bound > - add a `map_apply()` helper method to implement `Map::apply()`, that inserts new values instead of ignoring them --- ## Changelog TODO Co-authored-by: james7132 <contact@jamessliu.com>
james7132
added a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective This is a rebase of bevyengine#3701 which is currently scheduled for 0.8 but is marked for adoption. > Fixes bevyengine#3609 ## Solution > - add an `insert_boxed()` method on the `Map` trait > - implement it for `HashMap` using a new `FromReflect` generic bound > - add a `map_apply()` helper method to implement `Map::apply()`, that inserts new values instead of ignoring them --- ## Changelog TODO Co-authored-by: james7132 <contact@jamessliu.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective This is a rebase of bevyengine#3701 which is currently scheduled for 0.8 but is marked for adoption. > Fixes bevyengine#3609 ## Solution > - add an `insert_boxed()` method on the `Map` trait > - implement it for `HashMap` using a new `FromReflect` generic bound > - add a `map_apply()` helper method to implement `Map::apply()`, that inserts new values instead of ignoring them --- ## Changelog TODO Co-authored-by: james7132 <contact@jamessliu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This is a rebase of #3701 which is currently scheduled for 0.8 but is marked for adoption.
Solution
Changelog
TODO