[Merged by Bors] - Move the configuration of the WindowPlugin to a resource #5227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
approved these changes
Jul 8, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 8, 2022
# Objective It is currently hard to configure the `WindowPlugin`, as it is added as part of the `DefaultPlugins`. Ideally this should not be difficult. ## Solution Remove the configuration from the plugin itself and put it as a `Resource`, similar to how it is done for almost all other plugins. ## Migration Guide If you are currently configuring the behavior of the `WindowPlugin`, by constructing it manually, then you will need to instead create add the `WindowSettings` as a resource.
bors
bot
changed the title
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
…5227) # Objective It is currently hard to configure the `WindowPlugin`, as it is added as part of the `DefaultPlugins`. Ideally this should not be difficult. ## Solution Remove the configuration from the plugin itself and put it as a `Resource`, similar to how it is done for almost all other plugins. ## Migration Guide If you are currently configuring the behavior of the `WindowPlugin`, by constructing it manually, then you will need to instead create add the `WindowSettings` as a resource.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…5227) # Objective It is currently hard to configure the `WindowPlugin`, as it is added as part of the `DefaultPlugins`. Ideally this should not be difficult. ## Solution Remove the configuration from the plugin itself and put it as a `Resource`, similar to how it is done for almost all other plugins. ## Migration Guide If you are currently configuring the behavior of the `WindowPlugin`, by constructing it manually, then you will need to instead create add the `WindowSettings` as a resource.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…5227) # Objective It is currently hard to configure the `WindowPlugin`, as it is added as part of the `DefaultPlugins`. Ideally this should not be difficult. ## Solution Remove the configuration from the plugin itself and put it as a `Resource`, similar to how it is done for almost all other plugins. ## Migration Guide If you are currently configuring the behavior of the `WindowPlugin`, by constructing it manually, then you will need to instead create add the `WindowSettings` as a resource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
It is currently hard to configure the
WindowPlugin, as it is added as part of theDefaultPlugins. Ideally this should not be difficult.Solution
Remove the configuration from the plugin itself and put it as a
Resource, similar to how it is done for almost all other plugins.Migration Guide
If you are currently configuring the behavior of the
WindowPlugin, by constructing it manually, then you will need to instead create add theWindowSettingsas a resource.