[Merged by Bors] - Validate vertex attribute format on insert #5259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceSentry
changed the title
IceSentry
added
A-Rendering
afonsolage
reviewed
Jul 9, 2022
ManevilleF
approved these changes
Jul 9, 2022
|
Could you add a |
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
alice-i-cecile
approved these changes
Jul 9, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
irate-devil
approved these changes
Jul 9, 2022
| ); | ||
| let values: VertexAttributeValues = values.into(); | ||
|
|
||
| let values_format = VertexFormat::from(&values); |
There was a problem hiding this comment.
Kinda weird that this is a From impl instead of a .format() getter, and funnily enough this is going to be the only place it is used.
Ignore this comment, that's for another PR.
There was a problem hiding this comment.
That's fair, but why not add it to this PR? It would make that code clearer and it seems directly related.
There was a problem hiding this comment.
Ah, I just didn't want to push it onto you, could've worded that differently.
Feel free to :)
irate-devil
reviewed
Jul 9, 2022
Co-authored-by: ira <JustTheCoolDude@gmail.com>
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
# Objective - Validate the format of the values with the expected attribute format. - Currently, if you pass the wrong format, it will crash somewhere unrelated with a very cryptic error message, so it's really hard to debug for beginners. ## Solution - Compare the format and panic when unexpected format is passed ## Note - I used a separate `error!()` for a human friendly message because the panic message is very noisy and hard to parse for beginners. I don't mind changing this to only a panic if people prefer that. - This could potentially be something that runs only in debug mode, but I don't think inserting attributes is done often enough for this to be an issue. Co-authored-by: Charles <IceSentry@users.noreply.github.com>
|
Oops, I deleted the branch by mistake 😅 |
bors
bot
changed the title
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
# Objective - Validate the format of the values with the expected attribute format. - Currently, if you pass the wrong format, it will crash somewhere unrelated with a very cryptic error message, so it's really hard to debug for beginners. ## Solution - Compare the format and panic when unexpected format is passed ## Note - I used a separate `error!()` for a human friendly message because the panic message is very noisy and hard to parse for beginners. I don't mind changing this to only a panic if people prefer that. - This could potentially be something that runs only in debug mode, but I don't think inserting attributes is done often enough for this to be an issue. Co-authored-by: Charles <IceSentry@users.noreply.github.com>
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - Validate the format of the values with the expected attribute format. - Currently, if you pass the wrong format, it will crash somewhere unrelated with a very cryptic error message, so it's really hard to debug for beginners. ## Solution - Compare the format and panic when unexpected format is passed ## Note - I used a separate `error!()` for a human friendly message because the panic message is very noisy and hard to parse for beginners. I don't mind changing this to only a panic if people prefer that. - This could potentially be something that runs only in debug mode, but I don't think inserting attributes is done often enough for this to be an issue. Co-authored-by: Charles <IceSentry@users.noreply.github.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Validate the format of the values with the expected attribute format. - Currently, if you pass the wrong format, it will crash somewhere unrelated with a very cryptic error message, so it's really hard to debug for beginners. ## Solution - Compare the format and panic when unexpected format is passed ## Note - I used a separate `error!()` for a human friendly message because the panic message is very noisy and hard to parse for beginners. I don't mind changing this to only a panic if people prefer that. - This could potentially be something that runs only in debug mode, but I don't think inserting attributes is done often enough for this to be an issue. Co-authored-by: Charles <IceSentry@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Note
error!()for a human friendly message because the panic message is very noisy and hard to parse for beginners. I don't mind changing this to only a panic if people prefer that.