Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Minimally fix the known unsoundness in bevy_mikktspace #5299

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Minimally fix the known unsoundness in bevy_mikktspace #5299

wants to merge 2 commits into from

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Jul 12, 2022 •
edited
Loading

Objective

Solution

  • Fix the unsoundness in a minimal way
  • Obviously there might be others, but it seems unlikely we have any way to know about those

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change P-Unsound A bug that results in undefined compiler behavior A-Rendering Drawing game state to the screen labels Jul 12, 2022
@Nilirad Nilirad added A-Math Fundamental domain-agnostic mathematical operations A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change and removed A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change labels Jul 12, 2022
alice-i-cecile
alice-i-cecile approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing code is not fun to navigate, but these changes make sense. I'd rather ship with these than nothing.

@alice-i-cecile alice-i-cecile added this to the Bevy 0.8 milestone Jul 12, 2022
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 12, 2022
superdump
superdump approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look simple enough to me. @cart please take a look.

cart
cart approved these changes Jul 16, 2022
View reviewed changes
Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for making this easy on us! I really like the "fully safe port" effort, but I was not looking forward to reviewing that under these time constraints :)

@cart
Copy link
Member

cart commented Jul 16, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jul 16, 2022
@DJMcNab
Minimally fix the known unsoundness in bevy_mikktspace (#5299)
2f1af6f 
# Objective

- 0.8 is coming soon, and our mikktspace implementation is unsound - see gltf-rs/mikktspace#26
- Best not to ship that

## Solution

- Fix the unsoundness in a minimal way
- Obviously there might be others, but it seems unlikely we have any way to know about those
@bors
Copy link
Contributor

bors bot commented Jul 16, 2022

Build failed:

@cart
Copy link
Member

cart commented Jul 16, 2022

bors retry

bors bot pushed a commit that referenced this pull request Jul 16, 2022
@DJMcNab
Minimally fix the known unsoundness in bevy_mikktspace (#5299)
fe27312 
# Objective

- 0.8 is coming soon, and our mikktspace implementation is unsound - see gltf-rs/mikktspace#26
- Best not to ship that

## Solution

- Fix the unsoundness in a minimal way
- Obviously there might be others, but it seems unlikely we have any way to know about those
@bors
Copy link
Contributor

bors bot commented Jul 16, 2022

Build failed:

@mockersf
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Jul 16, 2022
@DJMcNab
Minimally fix the known unsoundness in bevy_mikktspace (#5299)
25d222b 
# Objective

- 0.8 is coming soon, and our mikktspace implementation is unsound - see gltf-rs/mikktspace#26
- Best not to ship that

## Solution

- Fix the unsoundness in a minimal way
- Obviously there might be others, but it seems unlikely we have any way to know about those
@mockersf
Copy link
Member

two previous CI failures are due to lack of disk space on windows

@bors
Copy link
Contributor

bors bot commented Jul 16, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Minimally fix the known unsoundness in bevy_mikktspace [Merged by Bors] - Minimally fix the known unsoundness in bevy_mikktspace Jul 16, 2022
@bors bors bot closed this Jul 16, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
@DJMcNab @inodentry
Minimally fix the known unsoundness in bevy_mikktspace (bevyengine#5299)
d69f373 
# Objective

- 0.8 is coming soon, and our mikktspace implementation is unsound - see gltf-rs/mikktspace#26
- Best not to ship that

## Solution

- Fix the unsoundness in a minimal way
- Obviously there might be others, but it seems unlikely we have any way to know about those
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@DJMcNab @james7132
Minimally fix the known unsoundness in bevy_mikktspace (bevyengine#5299)
25b357f 
# Objective

- 0.8 is coming soon, and our mikktspace implementation is unsound - see gltf-rs/mikktspace#26
- Best not to ship that

## Solution

- Fix the unsoundness in a minimal way
- Obviously there might be others, but it seems unlikely we have any way to know about those
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@DJMcNab @ItsDoot
Minimally fix the known unsoundness in bevy_mikktspace (bevyengine#5299)
3451da4 
# Objective

- 0.8 is coming soon, and our mikktspace implementation is unsound - see gltf-rs/mikktspace#26
- Best not to ship that

## Solution

- Fix the unsoundness in a minimal way
- Obviously there might be others, but it seems unlikely we have any way to know about those
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@cart cart cart approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change P-Unsound A bug that results in undefined compiler behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
Bevy 0.8
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@DJMcNab @cart @mockersf @superdump @alice-i-cecile @Nilirad