Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Export and register Mat2. #5324

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Export and register Mat2. #5324

wants to merge 1 commit into from

Conversation

irate-devil
Copy link
Contributor

Export and register a missing type from glam.

Reflect impls were already present, but not registered.

@Nilirad Nilirad added C-Usability A simple quality-of-life change that makes Bevy easier to use A-Math Fundamental domain-agnostic mathematical operations labels Jul 15, 2022
alice-i-cecile
alice-i-cecile approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this as trivial once CI is unbroken.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 15, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 15, 2022
@irate-devil
Export and register Mat2. (#5324)
56ee620 
Export and register a missing type from `glam`.

Reflect impls were already present, but not registered.


Co-authored-by: devil-ira <justthecooldude@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 15, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Export and register Mat2. [Merged by Bors] - Export and register Mat2. Jul 15, 2022
@bors bors bot closed this Jul 15, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
@irate-devil @inodentry
Export and register Mat2. (bevyengine#5324)
2d3e5bf 
Export and register a missing type from `glam`.

Reflect impls were already present, but not registered.


Co-authored-by: devil-ira <justthecooldude@gmail.com>
@irate-devil irate-devil deleted the export-mat2 branch October 21, 2022 15:11
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@irate-devil @james7132
Export and register Mat2. (bevyengine#5324)
3f452c7 
Export and register a missing type from `glam`.

Reflect impls were already present, but not registered.


Co-authored-by: devil-ira <justthecooldude@gmail.com>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@irate-devil @ItsDoot
Export and register Mat2. (bevyengine#5324)
a623486 
Export and register a missing type from `glam`.

Reflect impls were already present, but not registered.


Co-authored-by: devil-ira <justthecooldude@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@irate-devil @alice-i-cecile @Nilirad