Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove redundant Size import #5339

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Remove redundant Size import #5339

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 16, 2022

Objective

Solution

  • Remove the use crate::Size import so that the pub use geometry::* import also publicly uses the Size struct.

@ghost ghost added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets labels Jul 16, 2022
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Jul 16, 2022 •
edited
Loading

Merging as trivial; this got missed in the rename / migration.

bors r+

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 16, 2022
bors bot pushed a commit that referenced this pull request Jul 16, 2022
Remove redundant Size import (#5339)
f531a94 
# Objective

- Fixes  #5338 
- Allow the usage of `use bevy::ui::Size` (see migration guide in #4285)

## Solution

- Remove the `use crate::Size` import so that the `pub use geometry::*` import also publicly uses the `Size` struct.
@bors
Copy link
Contributor

bors bot commented Jul 16, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove redundant Size import [Merged by Bors] - Remove redundant Size import Jul 16, 2022
@bors bors bot closed this Jul 16, 2022
@ghost ghost deleted the remove_size_import branch August 7, 2022 08:27
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
@inodentry
Remove redundant Size import (bevyengine#5339)
682137f 
# Objective

- Fixes  bevyengine#5338 
- Allow the usage of `use bevy::ui::Size` (see migration guide in bevyengine#4285)

## Solution

- Remove the `use crate::Size` import so that the `pub use geometry::*` import also publicly uses the `Size` struct.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@james7132
Remove redundant Size import (bevyengine#5339)
59f2a2c 
# Objective

- Fixes  bevyengine#5338 
- Allow the usage of `use bevy::ui::Size` (see migration guide in bevyengine#4285)

## Solution

- Remove the `use crate::Size` import so that the `pub use geometry::*` import also publicly uses the `Size` struct.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@ItsDoot
Remove redundant Size import (bevyengine#5339)
3abd846 
# Objective

- Fixes  bevyengine#5338 
- Allow the usage of `use bevy::ui::Size` (see migration guide in bevyengine#4285)

## Solution

- Remove the `use crate::Size` import so that the `pub use geometry::*` import also publicly uses the `Size` struct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use bevy::ui::Size
1 participant
@alice-i-cecile