Add an example showing how to edit a scene before it's spawned #5872
Conversation
mockersf
added
C-Examples
alice-i-cecile
added
the
C-Breaking-Change
| @@ -25,6 +26,18 @@ impl Scene { | |||
| Self { world } | |||
| } | |||
|
|
|||
| /// Create a new scene from a given dynamic scene. | |||
There was a problem hiding this comment.
A little more explanation around the type registry parameter would be appreciated.
| .run(); | ||
| } | ||
|
|
||
| pub const CAKE_WITH_LIGHT_HANDLE: HandleUntyped = HandleUntyped::weak_from_u64(Scene::TYPE_UUID, 1); |
There was a problem hiding this comment.
I would add a comment explaining how these constants were chosen.
There was a problem hiding this comment.
would you believe me if I said "randomly selected value"? 😄
There was a problem hiding this comment.
grin Of course ;) Good to explain to the users though.
| .despawn_recursive(); | ||
|
|
||
| // add the modified scenes to the assets | ||
| scenes.set_untracked(CAKE_WITH_LIGHT_HANDLE, scene_with_lights); |
There was a problem hiding this comment.
set_untracked feels like a very unintuitive name for this behavior. Should it be renamed?
There was a problem hiding this comment.
set_untracked creates an asset that is not tracked for automatic cleanup, the name seems right?
There was a problem hiding this comment.
Why not create_untracked then? set to me implies that it's setting an existing asset.
Or even create_durable or something, to better communicate the intent.
|
converting to draft as most comments are related to how to do asset post processing, and it's just not something that can be pretty in Bevy for now |
Objective
Scene/DynamicScene