Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Bump MSRV to 1.67 #7379

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Bump MSRV to 1.67 #7379

wants to merge 1 commit into from

Conversation

james7132
Copy link
Member

Objective

Bump the MSRV to 1.67. Enable cleanup PRs like #7346 to work.

Solution

Bump it to 1.67

Changelog

Changed: The MSRV of the engine is now 1.67.

@james7132 james7132 added the C-Dependencies A change to the crates that Bevy depends on label Jan 27, 2023
@alice-i-cecile
Copy link
Member

Don't we have an automatic process for this? I remember @mockersf adding one.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 27, 2023
@james7132
Copy link
Member Author

Don't we have an automatic process for this? I remember @mockersf adding one.

We do. It's just that I wanted to unblock that other effort a bit early, haha.

@james7132
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jan 27, 2023
@james7132
Bump MSRV to 1.67 (#7379)
70e5117 
# Objective
Bump the MSRV to 1.67. Enable cleanup PRs like #7346 to work.

## Solution
Bump it to 1.67

---

## Changelog
Changed: The MSRV of the engine is now 1.67.
@bors
Copy link
Contributor

bors bot commented Jan 27, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Bump MSRV to 1.67 [Merged by Bors] - Bump MSRV to 1.67 Jan 27, 2023
@bors bors bot closed this Jan 27, 2023
@MinerSebas MinerSebas mentioned this pull request Jan 27, 2023
Closed
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@james7132 @ItsDoot
Bump MSRV to 1.67 (bevyengine#7379)
6272500 
# Objective
Bump the MSRV to 1.67. Enable cleanup PRs like bevyengine#7346 to work.

## Solution
Bump it to 1.67

---

## Changelog
Changed: The MSRV of the engine is now 1.67.
@james7132 james7132 deleted the msrv-1.67 branch February 18, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@JoJoJet JoJoJet JoJoJet approved these changes

@mockersf mockersf Awaiting requested review from mockersf

Assignees
No one assigned
Labels
C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@james7132 @alice-i-cecile @superdump @JoJoJet