Port hecs derive macro improvements #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moxinilian
added
A-ECS
|
Ooh very nice. Testing now |
|
Testing what?
On Sat, Nov 7, 2020 at 2:17 AM Carter Anderson ***@***.***> wrote:
Ooh very nice. Testing now
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#761 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHGK5TEW34F233SHEMSXSVTSORRWXANCNFSM4TGQUSDA>
.
--
Raza Amir
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ralith/hecs#104 and Ralith/hecs#105 improved the derive macro to properly support generics, tuple and unit structs as well improving panic messages when trying to create an archetype with duplicate components in debug mode. The macro is also now properly hygienic. This PR ports those changes over to bevy.
I didn't add the
trybuildtest suite as I don't know whether new dev-dependencies, are easily welcome or not. Let me know and I'll add that as well.