Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Allow adding systems to multiple sets that share the same base set #7709

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Allow adding systems to multiple sets that share the same base set #7709

wants to merge 2 commits into from

Conversation

geieredgar
Copy link
Contributor

Objective

Fixes #7702.

Solution

  • Added an test that ensures that no error is returned if a system or set is inside two different sets that share the same base set.
  • Added an check to only return an error if the two base sets are not equal.

@geieredgar geieredgar changed the title Fix 7702 Fix #7702 Feb 16, 2023
@geieredgar geieredgar changed the title Fix #7702 Allow adding systems to multiple sets that share the same base set Feb 16, 2023
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events labels Feb 16, 2023
@alice-i-cecile alice-i-cecile added this to the 0.10 milestone Feb 16, 2023
alice-i-cecile
alice-i-cecile approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good tests, good fix. Thanks!

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 16, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 16, 2023
@geieredgar
Allow adding systems to multiple sets that share the same base set (#…
6a63940 
…7709)

# Objective

Fixes #7702.

## Solution

- Added an test that ensures that no error is returned if a system or set is inside two different sets that share the same base set.
- Added an check to only return an error if the two base sets are not equal.
@bors
Copy link
Contributor

bors bot commented Feb 16, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Allow adding systems to multiple sets that share the same base set [Merged by Bors] - Allow adding systems to multiple sets that share the same base set Feb 16, 2023
@bors bors bot closed this Feb 16, 2023
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 16, 2023
@geieredgar @myreprise1
Allow adding systems to multiple sets that share the same base set (b…
f0aebac 
…evyengine#7709)

# Objective

Fixes bevyengine#7702.

## Solution

- Added an test that ensures that no error is returned if a system or set is inside two different sets that share the same base set.
- Added an check to only return an error if the two base sets are not equal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@JoJoJet JoJoJet JoJoJet approved these changes

@hymm hymm Awaiting requested review from hymm

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

Can't add systems to multiple sets.
3 participants
@geieredgar @alice-i-cecile @JoJoJet