[Merged by Bors] - Allow relative speed of -0.0 #7740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
approved these changes
Feb 18, 2023
james7132
added
C-Bug
TimJentzsch
approved these changes
Feb 18, 2023
mockersf
approved these changes
Feb 18, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 18, 2023
# Objective -0.0 should typically be treated exactly the same as 0.0, but this assertion was rejecting it while allowing 0.0. The `Duration` API handles this correctly (on recent Rust versions) and returns a zero `Duration` for both -0.0 and 0.0. ## Solution Check for `ratio >= 0.0`, which is true if `ratio` is `-0.0`. --- ## Changelog Allow relative speed of -0.0 in the `Time::set_relative_speed_fXX` methods.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 20, 2023
# Objective -0.0 should typically be treated exactly the same as 0.0, but this assertion was rejecting it while allowing 0.0. The `Duration` API handles this correctly (on recent Rust versions) and returns a zero `Duration` for both -0.0 and 0.0. ## Solution Check for `ratio >= 0.0`, which is true if `ratio` is `-0.0`. --- ## Changelog Allow relative speed of -0.0 in the `Time::set_relative_speed_fXX` methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
-0.0 should typically be treated exactly the same as 0.0, but this assertion was rejecting it while allowing 0.0. The
DurationAPI handles this correctly (on recent Rust versions) and returns a zeroDurationfor both -0.0 and 0.0.Solution
Check for
ratio >= 0.0, which is true ifratiois-0.0.Changelog
Allow relative speed of -0.0 in the
Time::set_relative_speed_fXXmethods.