[Merged by Bors] - for disconnected, use Vec instead of HashSet to reduce insert overhead #7744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bench result ➜ critcmp schedule_base schedule_optimize
group schedule_base schedule_optimize
----- ------------- -----------------
build_schedule/1000_schedule 1.07 2.3±0.15s ? ?/sec 1.00 2.1±0.11s ? ?/sec
build_schedule/1000_schedule_noconstraints 2.99 65.3±0.79ms ? ?/sec 1.00 21.8±0.37ms ? ?/sec
build_schedule/100_schedule 1.06 12.8±0.08ms ? ?/sec 1.00 12.2±0.07ms ? ?/sec
build_schedule/100_schedule_noconstraints 1.47 1300.6±15.21µs ? ?/sec 1.00 887.8±192.92µs ? ?/sec
build_schedule/500_schedule 1.04 388.1±5.32ms ? ?/sec 1.00 372.4±6.56ms ? ?/sec
build_schedule/500_schedule_noconstraints 2.50 16.1±0.14ms ? ?/sec 1.00 6.5±0.17ms ? ?/sec
schedule/base 1.00 25.7±0.22µs ? ?/sec 1.01 26.0±0.46µs ? ?/sec |
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Feb 19, 2023
maniwani
approved these changes
Feb 19, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 19, 2023
#7744) # Objective - Improve `Schedule::initialize` performance ## Solution - replace `disconnected`'s type from HashSet to Vec in `check_graph`
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Mar 23, 2023
bevyengine#7744) # Objective - Improve `Schedule::initialize` performance ## Solution - replace `disconnected`'s type from HashSet to Vec in `check_graph`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Schedule::initializeperformanceSolution
disconnected's type from HashSet to Vec incheck_graph