[Merged by Bors] - add common run conditions to bevy_input #7806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobhellermann
added
C-Enhancement
jakobhellermann
force-pushed
the
bevy-input-common-conditions
branch
from
9ec7e86
to
414d3a6
Compare
jakobhellermann
force-pushed
the
bevy-input-common-conditions
branch
from
414d3a6
to
42e1a3d
Compare
|
Quick and dirty! Convenient though. I'll look into adding the same in LWIM too. |
alice-i-cecile
approved these changes
Feb 24, 2023
Carter0
reviewed
Feb 25, 2023
Co-authored-by: Carter Weinberg <weinbergcarter@gmail.com>
Carter0
reviewed
Feb 25, 2023
| /// .run(); | ||
| /// } | ||
| /// | ||
| /// fn update_pause_state(mut paused: ResMut<Paused>, input: Input<KeyCode>) { |
There was a problem hiding this comment.
Nitpick: I think I see what you are going for, but it's a little confusing because I don't think update_pause_state is ever getting called. Should that be in the schedule somewhere?
Carter0
reviewed
Feb 25, 2023
| { | ||
| let mut active = default; | ||
| move |inputs: Res<Input<T>>| { | ||
| active ^= inputs.just_pressed(input); |
There was a problem hiding this comment.
Would you mind explaining what this symbol is ^= for my smooth brain pls lol. I think I understand but it'd be worth clarifying haha.
There was a problem hiding this comment.
It's xor assign. So basically if just_pressed { active = !active }.
Reading this I had to think for a minute to know why this works so I should probably just write the simpler clearer way lol
There was a problem hiding this comment.
It works because
inactive ^ not pressed -> inactive
inactive ^ pressed -> active
active ^ not pressed -> active
active ^ pressed -> inactive
There was a problem hiding this comment.
Yes, okay I think that makes sense to me lol.
Carter0
reviewed
Feb 25, 2023
| /// } | ||
| /// | ||
| /// ``` | ||
| pub fn input_toggle_active<T>(default: bool, input: T) -> impl FnMut(Res<Input<T>>) -> bool |
There was a problem hiding this comment.
❓ Where is this function getting called?
Carter0
reviewed
Feb 25, 2023
Carter0
approved these changes
Feb 25, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 25, 2023
# Objective
Common run conditions can be very useful for quick and ergonomic changes to when a system runs.
Specifically what I'd like to be able to do is
```rust
use bevy::prelude::*;
use bevy::input::common_conditions::input_toggle_active;
fn main() {
App::new()
.add_plugins(DefaultPlugins)
.add_plugin(
bevy_inspector_egui::quick::WorldInspectorPlugin::default()
.run_if(input_toggle_active(true, KeyCode::Escape)
)
.run();
}
```
## Solution
- add `bevy_input::common_conditions` module with `input_toggle_active`, `input_pressed`, `input_just_pressed`, `input_just_released`
## Changelog
- added common run conditions for `bevy_input`
- you can now use `.add_system(jump.run_if(input_just_pressed(KeyCode::Space)))`
bors
bot
changed the title
Shfty
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
# Objective
Common run conditions can be very useful for quick and ergonomic changes to when a system runs.
Specifically what I'd like to be able to do is
```rust
use bevy::prelude::*;
use bevy::input::common_conditions::input_toggle_active;
fn main() {
App::new()
.add_plugins(DefaultPlugins)
.add_plugin(
bevy_inspector_egui::quick::WorldInspectorPlugin::default()
.run_if(input_toggle_active(true, KeyCode::Escape)
)
.run();
}
```
## Solution
- add `bevy_input::common_conditions` module with `input_toggle_active`, `input_pressed`, `input_just_pressed`, `input_just_released`
## Changelog
- added common run conditions for `bevy_input`
- you can now use `.add_system(jump.run_if(input_just_pressed(KeyCode::Space)))`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Common run conditions can be very useful for quick and ergonomic changes to when a system runs.
Specifically what I'd like to be able to do is
Solution
bevy_input::common_conditionsmodule withinput_toggle_active,input_pressed,input_just_pressed,input_just_releasedChangelog
bevy_input.add_system(jump.run_if(input_just_pressed(KeyCode::Space)))