Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Color::as_rgba_linear for Color::Lcha #8040

Merged
merged 2 commits into from Mar 11, 2023
Merged

Fix Color::as_rgba_linear for Color::Lcha #8040

merged 2 commits into from Mar 11, 2023

Conversation

payload
Copy link
Contributor

@payload payload commented Mar 11, 2023

Objective

Fixes #8034"

Solution

  • fixed function return enum value
  • added a test for Color::as_rgba_linear for corrrect enum value

Changelog

  • Fixed Color::as_rgba_linear to return always RgbaLinear instead of Rgba for Lcha colors

@payload
Copy link
Contributor Author

payload commented Mar 11, 2023

A constructor for Lcha colors is missing. I would add that in a separat PR

@james7132 james7132 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Mar 11, 2023
@james7132 james7132 added this to the 0.10.1 milestone Mar 11, 2023
@payload payload mentioned this pull request Mar 11, 2023
Merged
@payload @james7132
Add regression test comment for bevyengine#8040
b3f3885 
Co-authored-by: James Liu <contact@jamessliu.com>
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 11, 2023
@mockersf mockersf added this pull request to the merge queue Mar 11, 2023
Merged via the queue into bevyengine:main with commit 9e9ae5b Mar 11, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@payload @james7132 @Shfty
Fix Color::as_rgba_linear for Color::Lcha (bevyengine#8040)
05aa138 
Co-authored-by: James Liu <contact@jamessliu.com>
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@payload @james7132 @Shfty
Fix Color::as_rgba_linear for Color::Lcha (bevyengine#8040)
3bf3976 
Co-authored-by: James Liu <contact@jamessliu.com>
mockersf pushed a commit that referenced this pull request Mar 27, 2023
@payload @james7132 @mockersf
Fix Color::as_rgba_linear for Color::Lcha (#8040)
572a836 
Co-authored-by: James Liu <contact@jamessliu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@mockersf mockersf mockersf approved these changes

@irate-devil irate-devil irate-devil approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10.1
Development

Successfully merging this pull request may close these issues.

Crash when setting background color via Color::Lcha
4 participants
@payload @james7132 @mockersf @irate-devil