Improve safety for the multi-threaded executor using UnsafeWorldCell
#8292
Conversation
alice-i-cecile
added
A-ECS
JoJoJet
added
the
C-Breaking-Change
|
Upon closer inspection, I noticed a couple more functions with undocumented invariants that had to be marked as |
|
I've resolved the issues I mentioned before. |
| @@ -476,7 +476,7 @@ where | |||
| } | |||
|
|
|||
| #[inline] | |||
| unsafe fn run_unsafe(&mut self, input: Self::In, world: &World) -> Self::Out { | |||
| unsafe fn run_unsafe(&mut self, input: Self::In, world: UnsafeWorldCell) -> Self::Out { | |||
There was a problem hiding this comment.
Really suprised we can elide the lifetime here.
There was a problem hiding this comment.
My preference is to always write UnsafeWorldCell<'_> to make it obvious this is happening.
Co-authored-by: James Liu <contact@jamessliu.com>
| @@ -476,7 +476,7 @@ where | |||
| } | |||
|
|
|||
| #[inline] | |||
| unsafe fn run_unsafe(&mut self, input: Self::In, world: &World) -> Self::Out { | |||
| unsafe fn run_unsafe(&mut self, input: Self::In, world: UnsafeWorldCell) -> Self::Out { | |||
There was a problem hiding this comment.
My preference is to always write UnsafeWorldCell<'_> to make it obvious this is happening.
I can do that if you prefer it strongly, but IMO that's just an uglier way of writing the same thing. Being explicit about lifetimes only adds clarity if you're going to name them -- otherwise, elision is preferred. I don't think that Anyway, thank you for the review. |
|
It's not a strong preference, we can keep it as is. |
JoJoJet
added
the
S-Ready-For-Final-Review
# Objective Follow-up to #6404 and #8292. Mutating the world through a shared reference is surprising, and it makes the meaning of `&World` unclear: sometimes it gives read-only access to the entire world, and sometimes it gives interior mutable access to only part of it. This is an up-to-date version of #6972. ## Solution Use `UnsafeWorldCell` for all interior mutability. Now, `&World` *always* gives you read-only access to the entire world. --- ## Changelog TODO - do we still care about changelogs? ## Migration Guide Mutating any world data using `&World` is now considered unsound -- the type `UnsafeWorldCell` must be used to achieve interior mutability. The following methods now accept `UnsafeWorldCell` instead of `&World`: - `QueryState`: `get_unchecked`, `iter_unchecked`, `iter_combinations_unchecked`, `for_each_unchecked`, `get_single_unchecked`, `get_single_unchecked_manual`. - `SystemState`: `get_unchecked_manual` ```rust let mut world = World::new(); let mut query = world.query::<&mut T>(); // Before: let t1 = query.get_unchecked(&world, entity_1); let t2 = query.get_unchecked(&world, entity_2); // After: let world_cell = world.as_unsafe_world_cell(); let t1 = query.get_unchecked(world_cell, entity_1); let t2 = query.get_unchecked(world_cell, entity_2); ``` The methods `QueryState::validate_world` and `SystemState::matches_world` now take a `WorldId` instead of `&World`: ```rust // Before: query_state.validate_world(&world); // After: query_state.validate_world(world.id()); ``` The methods `QueryState::update_archetypes` and `SystemState::update_archetypes` now take `UnsafeWorldCell` instead of `&World`: ```rust // Before: query_state.update_archetypes(&world); // After: query_state.update_archetypes(world.as_unsafe_world_cell_readonly()); ```
Objective
Fix #7833.
Safety comments in the multi-threaded executor don't really talk about system world accesses, which makes it unclear if the code is actually valid.
Solution
Update the
Systemtrait to useUnsafeWorldCell. This type's API is written in a way that makes it much easier to cleanly maintain safety invariants. Use this type throughout the multi-threaded executor, with a liberal use of safety comments.Migration Guide
The
Systemtrait now usesUnsafeWorldCellinstead of&World. This type provides a robust API for interior mutable world access.run_unsafeuses this type to manage world mutations across multiple threads.update_archetype_component_accessuses this type to ensure that only world metadata can be used.