Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RenderGraphApp in more places #8298

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Use RenderGraphApp in more places #8298

merged 1 commit into from
Apr 5, 2023

Conversation

IceSentry
Copy link
Contributor

@IceSentry IceSentry commented Apr 4, 2023 •
edited by cart
Loading

Objective

  • RenderGraphExt was merged, but only used in limited situations

Solution

  • Fix some remaining issues with the existing api
  • Use the new api in the main pass and mass writeback
  • Add CORE_2D and CORE_3D constant to make render_graph code shorter

@IceSentry IceSentry added A-Rendering Drawing game state to the screen C-Enhancement A new feature labels Apr 4, 2023
@cart cart changed the title Use RenderGraphExt in more places Use RenderGraphApp in more places Apr 5, 2023
cart
cart approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still forming opinions on the use graph::* pattern, but I'm pretty sure I like it more. Nice work!

@cart cart added this pull request to the merge queue Apr 5, 2023
Merged via the queue into bevyengine:main with commit c70776b Apr 5, 2023
@IceSentry
Copy link
Contributor Author

yeah, the use graph::* stuff was mostly an experiment to see how it felt. I only used it in places where there was a lot of duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Enhancement A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IceSentry @cart @mockersf