Add any_component_removed condition
#8326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
requested changes
Apr 7, 2023
| // Simply checking `is_empty` would not be enough. | ||
| // PERF: note that `count` is efficient (not actually looping/iterating), | ||
| // due to Bevy having a specialized implementation for events. | ||
| move |mut removals: RemovedComponents<T>| !removals.iter().count() != 0 |
There was a problem hiding this comment.
Suggested change
| move |mut removals: RemovedComponents<T>| !removals.iter().count() != 0 | |
| move |mut removals: RemovedComponents<T>| removals.iter().next().is_none() |
This otherwise potentially does a full traversal.
There was a problem hiding this comment.
This contradicts the perf note above.
I would still prefer to remove the perf note and just use is_empty though.
There was a problem hiding this comment.
Oh I completely forgot we overrode the default implementations for those. Agreed on the use of is_empty instead.
There was a problem hiding this comment.
is_empty can't be used. The reason is mentioned in the comment: it won't advance the reader and the condition will be triggered twice. We use the same strategy for events:
james7132
added
C-Enhancement
james7132
approved these changes
Apr 18, 2023
james7132
added
the
S-Ready-For-Final-Review
mockersf
reviewed
Apr 18, 2023
Co-authored-by: François <mockersf@gmail.com>
alice-i-cecile
approved these changes
Apr 18, 2023
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added helper extracted from #7711. that PR contains some controversy conditions, but this one should be good to go.
Changelog
Added
any_component_removedcondition.