ChildBuilder docs improvement #8371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicopap
suggested changes
Apr 13, 2023
There was a problem hiding this comment.
Is this PR still a WIP? Make sure to put it in draft mode if you still have work to do.
I don't think this solves #7230. It only superficially changes two docs. Have you looked at the other methods and judged they were good as-is? If so, it is perfectly fine, but mention it please.
Otherwise, I don't think the provided modifications are improvements, I gave inline suggestions on possible improvements.
nicopap
added
C-Docs
nicopap
suggested changes
Apr 14, 2023
nicopap
suggested changes
Apr 15, 2023
nicopap
approved these changes
Apr 15, 2023
Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
alice-i-cecile
approved these changes
Apr 22, 2023
Estus-Dev
pushed a commit
to Estus-Dev/bevy
that referenced
this pull request
Jul 10, 2023
# Objective Fixes bevyengine#7230 ## Solution Documented some side-effects --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #7230
Solution
Documented some side-effects