Add gamepad rumble support to bevy_input #8398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `RumbleRequest` event and a system to read them and rumble controllers accordingly. It gives users two ways of controlling controller rumble: 1. A very primitive API with `RumbleIntensity` that is easy to understand and use. 2. A direct access to the girls `ff::Effect` system for complete fine-grained control over how the gamepad rumbles.
Conflicts: crates/bevy_gilrs/Cargo.toml crates/bevy_gilrs/src/lib.rs crates/bevy_gilrs/src/rumble.rs examples/README.md examples/input/gamepad_rumble.rs
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
|
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
non-wasm, for now
johanhelsing
commented
Apr 16, 2023
johanhelsing
commented
Apr 16, 2023
johanhelsing
commented
Apr 16, 2023
johanhelsing
commented
Apr 16, 2023
nicopap
suggested changes
Apr 20, 2023
Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
nicopap
approved these changes
Apr 20, 2023
B-Reif
reviewed
Apr 22, 2023
alice-i-cecile
requested changes
Apr 22, 2023
How so? As far as i understand it shouldn't be needed: rust-lang/rust#71269 Or do you mean for clarity of intent? |
Co-authored-by: Bruce Reif (Buswolley) <bruce.reif@dynata.com>
|
Ah, TIL. Can we add tests for it instead then? |
There already are some ;) |
|
I think a single line comment on the |
alice-i-cecile
approved these changes
Apr 23, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Provide the ability to trigger controller rumbling (force-feedback) with a cross-platform API.
Solution
This adds the
GamepadRumbleRequestevent tobevy_inputand adds a system inbevy_gilrsto read them and rumble controllers accordingly.It's a relatively primitive API with a
durationin seconds andGamepadRumbleIntensitywith values for the weak and strong gamepad motors. It's is an almost 1-to-1 mapping to platform APIs. Some platforms refer to these motors as left and right, and low frequency and high frequency, but by convention, they're usually the same.I used #3868 as a starting point, updated to main, removed the low-level gilrs effect API, and moved the requests to
bevy_inputand exposed the strong and weak intensities.I intend this to hopefully be a non-controversial cross-platform starting point we can build upon to eventually support more fine-grained control (closer to the gilrs effect API)
Changelog
Added
GamepadRumbleRequestevent.