Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pbr shader breaking on missing UVs #8412

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Fix pbr shader breaking on missing UVs #8412

merged 1 commit into from
Apr 17, 2023

Conversation

nicopap
Copy link
Contributor

@nicopap nicopap commented Apr 17, 2023

Objective

Fix #8409

Since in doesn't have a uv field when VERTEX_UVS is not defined, it shouldn't be accessed outside of related #ifdefs

@nicopap nicopap added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Apr 17, 2023
@james7132 james7132 added this to the 0.11 milestone Apr 17, 2023
@james7132 james7132 added this pull request to the merge queue Apr 17, 2023
@james7132 james7132 added the A-Animation Make things move and change over time label Apr 17, 2023
Merged via the queue into bevyengine:main with commit c488b70 Apr 17, 2023
@nicopap nicopap mentioned this pull request Apr 17, 2023
Open
9 tasks
@nicopap nicopap deleted the good_uv branch August 30, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Animation Make things move and change over time A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

Skinned mesh examples show blank screen and shader error
3 participants
@nicopap @james7132 @mockersf