Compute vertex_count for indexed meshes on GpuMesh
#8460
Conversation
| @@ -834,9 +835,7 @@ pub enum GpuBufferInfo { | |||
| count: u32, | |||
There was a problem hiding this comment.
The vertex count would be stored twice (once in GpuMesh.vertex_count field, once in GpuMesh.buffer_info.Indexed.count) With this solution.
Why not define vertex_count() as a method on GpuMesh? This way you inspect the content of buffer_info and return the value of either NonIndex.vertex_count or Indexed.count.
There was a problem hiding this comment.
The count stored there is the size of the index buffer, not the amount of vertices in the mesh
There was a problem hiding this comment.
The same thing confused me at first. Imo, we should rename Indexed.count to Indexed.index_count or something.
There was a problem hiding this comment.
size would be appropriate then
|
Oh hey, I also needed this for my path tracing stuff. I have basically the same change in my fork lol. Thanks for the PR! |
Selene-Amanita
added
A-Rendering
Objective
Compute the
vertex_countfor indexed meshes as well as non-indexed meshes.I will need this in a future PR based on #8427 that adds a gizmo component that draws the normals of a mesh when attached to an entity (branch).
Example image
Solution
Move
vertex_countfield fromGpuBufferInfo::NonIndexedtoGpuMeshMigration Guide
vertex_countis now stored directly onGpuMeshinstead ofGpuBufferInfo::NonIndexed.