Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix screenshots on Wayland + Nvidia #8701

Merged
merged 2 commits into from May 29, 2023
Merged

Fix screenshots on Wayland + Nvidia #8701

merged 2 commits into from May 29, 2023

Conversation

irate-devil
Copy link
Contributor

Objective

Fix #8604

Solution

Use .add_srgb_suffix() when creating the screenshot texture.
Allow converting Bgra8Unorm images.

Only a two line change for the fix, the screenshot.rs changes are just a bit of cleanup.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels May 28, 2023
@alice-i-cecile alice-i-cecile added the C-Examples An addition or correction to our examples label May 28, 2023
mockersf
mockersf approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, can someone on wayland confirm it works?

@VitalyAnkh
Copy link
Contributor

I confirm it works on Wayland + Nvidia. Nice!

@mockersf mockersf added this pull request to the merge queue May 29, 2023
Merged via the queue into bevyengine:main with commit 5e3ae77 May 29, 2023
24 checks passed
@irate-devil irate-devil deleted the fix-screenshot-non-srgb branch June 2, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

@VitalyAnkh VitalyAnkh VitalyAnkh approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

screenshot example crashes on Linux, Wayland with Nvidia GPU
4 participants
@irate-devil @VitalyAnkh @alice-i-cecile @mockersf