Make UVSphere
3d shape use Y-up convention
#8717
Open
+7
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Before
After
Solution
y
andz
in the math and also swapped first and second triangle indexes to preserve right-handedness;Changelog
Changed
UVSphere
Y-up (instead of Z-up) for consistency with other 3d shapes and Bevy's convention;Migration Guide
UVSphere
poles are now on +Y, -Y. If you're currently relying onUVSphere
poles being +Z, -Z, (e.g. for texturing/uv mapping purposes) you must rotate yourUVSphere
byPI / 2.0
(90º) on the X axis;