Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip check change tick for apply_deferred systems #8760

Merged
merged 1 commit into from
Jun 6, 2023
Merged

skip check change tick for apply_deferred systems #8760

merged 1 commit into from
Jun 6, 2023

Conversation

hymm
Copy link
Contributor

@hymm hymm commented Jun 5, 2023

Objective

Solution

  • Skip the check that produces the warning for apply_buffers systems.

Changelog

  • skip check_change_ticks for apply_buffers systems.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Diagnostics Logging, crash handling, error reporting and performance analysis and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jun 5, 2023
@james7132 james7132 added this pull request to the merge queue Jun 6, 2023
Merged via the queue into bevyengine:main with commit 0a90bac Jun 6, 2023
26 checks passed
@ickshonpe ickshonpe mentioned this pull request Jun 28, 2023
Closed
@hymm hymm deleted the apply-buffers-change-detection branch July 13, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Useless warnings about apply_system_buffers ticks
3 participants
@hymm @james7132 @alice-i-cecile