Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bevy_reflect: implement Reflect for SmolStr #8771

Merged
merged 9 commits into from Jun 8, 2023
Merged

bevy_reflect: implement Reflect for SmolStr #8771

merged 9 commits into from Jun 8, 2023

Commits on Jun 6, 2023

  1. bevy_reflect: implement Reflect for SmolStr 

    Prompted by winit's update bevyengine#8745.
    @Vrixyz
    Vrixyz committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    cf33bdc View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Fix typo 

    Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com>
    @alice-i-cecile @MrGVSV
    alice-i-cecile and MrGVSV committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    863314e View commit details
    Browse the repository at this point in the history

  2. doc PR suggestion 

    Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com>
    @Vrixyz @MrGVSV
    Vrixyz and MrGVSV committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    4ac3550 View commit details
    Browse the repository at this point in the history

  3. test cleanup 

    Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com>
    @Vrixyz @MrGVSV
    Vrixyz and MrGVSV committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    e3d0db0 View commit details
    Browse the repository at this point in the history

  4. add TypePath + new test + fix inner representation to SmolStr

    @Vrixyz
    Vrixyz committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    6faeef2 View commit details
    Browse the repository at this point in the history

  5. removed serialization ; register FromReflect

    @Vrixyz
    Vrixyz committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    8e26f03 View commit details
    Browse the repository at this point in the history

  6. Update crates/bevy_reflect/src/impls/smol_str.rs 

    Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com>
    @Vrixyz @MrGVSV
    Vrixyz and MrGVSV committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    85ba7f5 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. aggregated feature smol_str to bevy, because SmolStr is exposed withi… 

    …n bevy_input and needs Refrlect derives.
    @Vrixyz
    Vrixyz committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    012bd90 View commit details
    Browse the repository at this point in the history

  2. use derive macros to simplify code and avoid silly manual mistakes 

    We can revisit that when need be.
    @Vrixyz
    Vrixyz committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    cc73745 View commit details
    Browse the repository at this point in the history