Add get_ref to EntityRef #8818
Merged
Add get_ref to EntityRef #8818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To mirror the `Ref` added as `WorldQuery`, and the `Mut` in `EntityMut::get_mut`, we add `EntityRef::get_ref`, which retrieves `T` with tick informations, but *immutably*.
nicopap
added
C-Enhancement
alice-i-cecile
approved these changes
Jun 11, 2023
JoJoJet
approved these changes
Jun 11, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
james7132
reviewed
Jun 12, 2023
alice-i-cecile
removed
the
S-Ready-For-Final-Review
Co-authored-by: James Liu <contact@jamessliu.com>
james7132
approved these changes
Jun 12, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mockersf
approved these changes
Jun 12, 2023
mockersf
added
the
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
To mirror the
Refadded asWorldQuery, and theMutinEntityMut::get_mut, we addEntityRef::get_ref, which retrievesTwith tick information, but immutably.Solution
UnsafeEntityCellsince this seems to be the best way of getting that information.Also update/add safety comments to neighboring code.
Changelog
EntityRef::get_refto get anOption<Ref<T>>fromEntityRef