New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Growing UI nodes Fix #8931
Merged
Merged
Growing UI nodes Fix #8931
Commits on Jun 21, 2023
-
Taffy's `round_layout` uses a rounding function that rounds away from zero, so x bounds from -100.5 to 99.5 (width 100) will be rounded to -101 to 101 (width 101), gaining a pixel. This commit disables Taffy's builtin rounding with a function that round halfs up rather than rounding them towards zero.
Configuration menu - View commit details
-
Copy full SHA for 626ce48 - Browse repository at this point
Copy the full SHA 626ce48View commit details
Commits on Jun 22, 2023
-
Taffy's builtin rounding is disabled and rounding is now performed by `ui_layout_system`. Instead of rounding the values of the internal layout tree as Taffy's builtin rounding does, we leave those values unmodified and only the values stored in the components are rounded. This requires that we walk the tree for the uinode geometry update rather than iterating through a query. Because the component values are regenerated each update, that should mean that UI updates are idempotent now and make the growing node behaviour seen in issue bevyengine#8911 impossible. Added two helper functions `round_ties_up` and `round_layout_coordinates`.
Configuration menu - View commit details
-
Copy full SHA for c43ce29 - Browse repository at this point
Copy the full SHA c43ce29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8209ca7 - Browse repository at this point
Copy the full SHA 8209ca7View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf274a1 - Browse repository at this point
Copy the full SHA bf274a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33d675c - Browse repository at this point
Copy the full SHA 33d675cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1881910 - Browse repository at this point
Copy the full SHA 1881910View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c9c285 - Browse repository at this point
Copy the full SHA 0c9c285View commit details -
Configuration menu - View commit details
-
Copy full SHA for de5653b - Browse repository at this point
Copy the full SHA de5653bView commit details
Commits on Jun 24, 2023
-
bevy_ui::layout::round_ties_up
* Added comments explaining the behaviour of the `round_ties_up` function. * Changed the first predicate to use `<=` instead of `<`. This doesn't change the function's behaviour (since `(0.).ceil() == 0.`) but it feels like it makes it a little easier to undertand.
Configuration menu - View commit details
-
Copy full SHA for 33f47a0 - Browse repository at this point
Copy the full SHA 33f47a0View commit details
Commits on Jul 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d1b1aef - Browse repository at this point
Copy the full SHA d1b1aefView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.