Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run update_previous_view_projections in PreUpdate schedule #9024

Merged
merged 1 commit into from Jul 5, 2023
Merged

Run update_previous_view_projections in PreUpdate schedule #9024

merged 1 commit into from Jul 5, 2023

Conversation

geieredgar
Copy link
Contributor

Objective

Solution

Since a camera's view and projection matrices are modified during PostUpdate in camera_system and propagate_transforms, it is fine to move update_previous_view_projections from Update to PreUpdate.
Doing so adds consistence with update_mesh_previous_global_transforms and allows systems in Update to use PreviousViewProjection correctly without explicit ordering.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use labels Jul 4, 2023
@alice-i-cecile alice-i-cecile added C-Breaking-Change A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

@JMS55
Copy link
Contributor

JMS55 commented Jul 4, 2023

@alice-i-cecile this is not a breaking change - this code wasn't in bevy 0.10 before.

@mockersf mockersf removed the C-Breaking-Change A breaking change to Bevy's public API that needs to be noted in a migration guide label Jul 5, 2023
@mockersf mockersf added this pull request to the merge queue Jul 5, 2023
Merged via the queue into bevyengine:main with commit e03dd4d Jul 5, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

@JMS55 JMS55 JMS55 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maybe wrong schedule for update_previous_view_projections
4 participants
@geieredgar @JMS55 @alice-i-cecile @mockersf