Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example showcase - pagination and can build for WebGL2 #9168

Merged
merged 3 commits into from Jul 17, 2023
Merged

example showcase - pagination and can build for WebGL2 #9168

merged 3 commits into from Jul 17, 2023

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jul 15, 2023 •
edited

Objective

  • Building all examples at once in CI takes too long
  • Tool can only build for WebGPU

Solution

  • Add pagination to commands
  • Add option to build examples for WebGL2
  • Add option to build Zola files for WebGL2

@mockersf mockersf mentioned this pull request Jul 16, 2023
Merged
@cart cart added this pull request to the merge queue Jul 17, 2023
Merged via the queue into bevyengine:main with commit ff89968 Jul 17, 2023
20 checks passed
@mockersf mockersf mentioned this pull request Jul 18, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 18, 2023
@mockersf
example showcase: switch default api to webgpu (#9193)
7fe0853 
# Objective

- in #9168 I did some change to the showcase script, introducing the
notion of web api and setting the default Web API to webgl2
- that script was actually only called for webgpu example, so that
should have been the default value
@rparrett rparrett mentioned this pull request Aug 9, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 9, 2023
@rparrett
Fix gamepad viewer being marked as a non-wasm example (#9399)
e87d3cc 
# Objective

This example stopped being built for the website after the
example-building was reworked in
(bevyengine/bevy-website#720 + #9168).

This seems to have just been a mistake when defining this particular
example's metadata.

See bevyengine/bevy-website#726

## Solution

Update its metadata to indicate that it works with wasm.
cart pushed a commit that referenced this pull request Aug 10, 2023
@rparrett @cart
Fix gamepad viewer being marked as a non-wasm example (#9399)
e20b78f 
# Objective

This example stopped being built for the website after the
example-building was reworked in
(bevyengine/bevy-website#720 + #9168).

This seems to have just been a mistake when defining this particular
example's metadata.

See bevyengine/bevy-website#726

## Solution

Update its metadata to indicate that it works with wasm.
@cart cart mentioned this pull request Oct 13, 2023
Merged
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mockersf @cart