Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update text example using default font #9259

Merged
merged 2 commits into from Jul 24, 2023
Merged

Update text example using default font #9259

merged 2 commits into from Jul 24, 2023

Conversation

lewiszlw
Copy link
Member

@mockersf
Copy link
Member

Could you just remove the fonts/FiraMono-Medium.ttf font, but keep both uses of the fonts/FiraSans-Bold.ttf? Adding a comment like "this font is loaded and will be used instead of the default font"

@mockersf mockersf added C-Examples An addition or correction to our examples A-UI Graphical user interfaces, styles, layouts, and widgets labels Jul 24, 2023
@lewiszlw
Copy link
Member Author

Could you just remove the fonts/FiraMono-Medium.ttf font, but keep both uses of the fonts/FiraSans-Bold.ttf? Adding a comment like "this font is loaded and will be used instead of the default font"

Done.

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 24, 2023
@james7132 james7132 added this pull request to the merge queue Jul 24, 2023
@Selene-Amanita Selene-Amanita added this to the 0.11.1 milestone Jul 24, 2023
Merged via the queue into bevyengine:main with commit dfe462b Jul 24, 2023
21 checks passed
cart pushed a commit that referenced this pull request Aug 10, 2023
@lewiszlw @cart
Update text example using default font (#9259)
987d0aa 
# Objective

- Fixes #9233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@mockersf mockersf mockersf approved these changes

@Selene-Amanita Selene-Amanita Selene-Amanita approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.11.1
Development

Successfully merging this pull request may close these issues.

Default font feature is hard to discover
4 participants
@lewiszlw @mockersf @james7132 @Selene-Amanita